Bug 45307 - http/tests/navigation/anchor-frames.html should not be diffing images
Summary: http/tests/navigation/anchor-frames.html should not be diffing images
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other All
: P2 Normal
Assignee: Mihai Parparita
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-07 10:12 PDT by Mihai Parparita
Modified: 2010-09-08 19:10 PDT (History)
6 users (show)

See Also:

Attachments
Patch (110.79 KB, patch)
2010-09-07 10:15 PDT, Mihai Parparita 		dglazkov: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mihai Parparita 2010-09-07 10:12:45 PDT 
http/tests/navigation/anchor-frames.html should not be diffing images
Comment 1 Mihai Parparita 2010-09-07 10:15:18 PDT 
Created attachment 66736 [details]
Patch
Comment 2 Mihai Parparita 2010-09-07 10:17:02 PDT 
Dimitri, mind reviewing this?
Comment 3 Dimitri Glazkov (Google) 2010-09-07 15:54:42 PDT 
Comment on attachment 66736 [details]
Patch

great!
Comment 4 WebKit Commit Bot 2010-09-07 18:05:49 PDT 
Comment on attachment 66736 [details]
Patch

Rejecting patch 66736 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Dimitri Glazkov', u'--force']" exit_code: 255
Last 500 characters of output:
h-anchor.html
patching file LayoutTests/platform/chromium-linux/http/tests/navigation/anchor-frames-expected.checksum
rm 'LayoutTests/platform/chromium-linux/http/tests/navigation/anchor-frames-expected.checksum'
literal is only avaliable with the XS version at /Library/Perl/5.8.8/Compress/Zlib.pm line 9
BEGIN failed--compilation aborted at /Library/Perl/5.8.8/Compress/Zlib.pm line 9.
Compilation failed in require at /Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/VCSUtils.pm line 1670.

Full output: http://queues.webkit.org/results/3969295
Comment 5 Mihai Parparita 2010-09-07 18:07:38 PDT 
Eric, any ideas why the cq couldn't apply the patch? The failure looks different from the one in the EWS bot logs.
Comment 6 Eric Seidel (no email) 2010-09-07 18:11:21 PDT 
Dan knows much more about svn-apply than I do these days.
Comment 7 Eric Seidel (no email) 2010-09-07 18:11:47 PDT 
Oh, but this is just a cq perl install problem.  Sorry, for the time being the cq can't handle git binary patches.  Workign on fixing...
Comment 8 Mihai Parparita 2010-09-07 18:15:56 PDT 
(In reply to comment #7)
> Oh, but this is just a cq perl install problem.  Sorry, for the time being the cq can't handle git binary patches.  Workign on fixing...

Ah, hadn't realized that this applies to deletes too.

Dimitri, mind landing this?
Comment 9 Dimitri Glazkov (Google) 2010-09-08 16:21:08 PDT 
Landed as http://trac.webkit.org/changeset/67033.
Comment 11 Mihai Parparita 2010-09-08 19:10:32 PDT 
(In reply to comment #10)
> http://trac.webkit.org/changeset/67033 might have broken SnowLeopard Intel Release (Tests)

It is this patch's fault, bug 45430 is already filed about it.