Bug 4529 - Forgotten memcpy() in CGShading code
Summary: Forgotten memcpy() in CGShading code
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P4 Normal
Assignee: Eric Seidel (no email)
Depends on:
Reported: 2005-08-19 09:47 PDT by Eric Seidel (no email)
Modified: 2005-08-19 14:49 PDT (History)
0 users

See Also:

Fixes forgotten memcpy (928 bytes, patch)
2005-08-19 09:51 PDT, Eric Seidel (no email)
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2005-08-19 09:47:14 PDT
Looks fine to me.  You should not have to do any range clamping yourself.

Perhaps the bug is in 

static void cgGradientCallback(void *info, const float *inValues, float *outColor)

    } else if (!(inValue < stops[stopsCount-1].offset)) {
        outColor = stops[stopsCount-1].colorArray;
        // How does this work again !!!
    } else {

Comment 1 Eric Seidel (no email) 2005-08-19 09:51:52 PDT
Created attachment 3470 [details]
Fixes forgotten memcpy