RESOLVED FIXED 45283
[DRT/Chromium] Implement --check-layout-test-sys-deps 
https://bugs.webkit.org/show_bug.cgi?id=45283
Summary [DRT/Chromium] Implement --check-layout-test-sys-deps
Kent Tamura
Reported 2010-09-06 21:59:31 PDT
[DRT/Chromium] Implement --check-layout-test-sys-deps
Attachments
Patch (8.30 KB, patch)
2010-09-06 22:01 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2010-09-06 22:01:50 PDT
Created attachment 66685 [details] Patch
Kent Tamura
Comment 2 2010-09-07 06:20:30 PDT
Note: The original code is here: http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/test_shell_platform_delegate_win.cc?annotate=42071#l39 When this change is committed, the Windows test buildbot might stop working. We need to change the local machine settings in that case.
Dimitri Glazkov (Google)
Comment 3 2010-09-07 09:59:13 PDT
Comment on attachment 66685 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=66685&action=prettypatch ok. > WebKitTools/DumpRenderTree/chromium/TestShellWin.cpp:201 > + int verticalScrollSize = ::GetSystemMetrics(SM_CXVSCROLL); I wonder if I took care of this requirement and it's no longer necessary to check for . Not sure :)
Kent Tamura
Comment 4 2010-09-07 14:00:14 PDT
Comment on attachment 66685 [details] Patch Clearing flags on attachment: 66685 Committed r66906: <http://trac.webkit.org/changeset/66906>
Kent Tamura
Comment 5 2010-09-07 14:00:24 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 6 2010-09-07 19:39:02 PDT
http://trac.webkit.org/changeset/66906 might have broken Leopard Intel Debug (Tests) The following changes are on the blame list: http://trac.webkit.org/changeset/66905 http://trac.webkit.org/changeset/66906
Note You need to log in before you can comment on or make changes to this bug.