Bug 45270 - [v8] Inline hot methods for V8 to WebCore and back conversions
Summary: [v8] Inline hot methods for V8 to WebCore and back conversions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: anton muhin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-06 09:13 PDT by anton muhin
Modified: 2010-09-06 10:47 PDT (History)
1 user (show)

See Also:


Attachments
Patch (13.38 KB, patch)
2010-09-06 09:20 PDT, anton muhin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description anton muhin 2010-09-06 09:13:00 PDT
[v8] Inline hot methods for V8 to WebCore and back conversions
Comment 1 anton muhin 2010-09-06 09:15:39 PDT
This slightly increases the size of binary (< 0.1% for chrome built on Ubuntu for 32-bit platform and ~0.1% of chrome.dll for release, but not official branding), but gives 3--5% of speed up on Windows and up to 8% on 32bit Ubuntu.
Comment 2 anton muhin 2010-09-06 09:20:05 PDT
Created attachment 66651 [details]
Patch
Comment 3 Adam Barth 2010-09-06 09:34:41 PDT
Comment on attachment 66651 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=66651&action=prettypatch

> WebCore/ChangeLog:12
> +        That slightly increases the size of binary (within 0.1% for both Ubuntu
> +        and Windows, but those builds are slightly different from official ones),
> +        but gives performance boost (3--5% on Windows, up to 8% on Ubuntu).
On which benchmark?  Just curious.
Comment 4 anton muhin 2010-09-06 09:47:34 PDT
(In reply to comment #3)
> (From update of attachment 66651 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=66651&action=prettypatch
> 
> > WebCore/ChangeLog:12
> > +        That slightly increases the size of binary (within 0.1% for both Ubuntu
> > +        and Windows, but those builds are slightly different from official ones),
> > +        but gives performance boost (3--5% on Windows, up to 8% on Ubuntu).
> On which benchmark?  Just curious.

Thanks a lot for a quick review on Labour Day, Adam.

I should have mentioned it explicitly, but the benchmark is Dromaeo DOM core.
Comment 5 WebKit Commit Bot 2010-09-06 10:47:12 PDT
Comment on attachment 66651 [details]
Patch

Clearing flags on attachment: 66651

Committed r66840: <http://trac.webkit.org/changeset/66840>
Comment 6 WebKit Commit Bot 2010-09-06 10:47:17 PDT
All reviewed patches have been landed.  Closing bug.