RESOLVED FIXED 45268
[Qt] Symbian scoping in Qt build profile is wrong 
https://bugs.webkit.org/show_bug.cgi?id=45268
Summary [Qt] Symbian scoping in Qt build profile is wrong
Kristian Amlie
Reported 2010-09-06 07:51:38 PDT
Created attachment 66644 [details] Patch The part in WebCore.pro that refers to missing install functionality is scoped under "symbian", however it should only apply to "symbian-abld" and "symbian-sbsv2".
Attachments
Patch (1.73 KB, patch)
2010-09-06 07:51 PDT, Kristian Amlie 		hausmann: review-
hausmann: commit-queue-
DetailsFormatted DiffDiff
Patch v2 (1.84 KB, patch)
2010-09-09 00:09 PDT, Kristian Amlie 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Hausmann
Comment 1 2010-09-07 08:05:16 PDT
Comment on attachment 66644 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=66644&action=prettypatch Patch looks okay, but r- because of missing url to bugzilla in the ChangeLog and missing [Qt] as suffix "Fixed incorrect..." should be "[Qt] Fixed incorrect". Could you fix that? :)
Kristian Amlie
Comment 2 2010-09-09 00:09:42 PDT
Created attachment 67001 [details] Patch v2
Andreas Kling
Comment 3 2010-09-09 04:41:05 PDT
Comment on attachment 67001 [details] Patch v2 LGTM
WebKit Commit Bot
Comment 4 2010-09-09 05:05:19 PDT
Comment on attachment 67001 [details] Patch v2 Clearing flags on attachment: 67001 Committed r67080: <http://trac.webkit.org/changeset/67080>
WebKit Commit Bot
Comment 5 2010-09-09 05:05:24 PDT
All reviewed patches have been landed. Closing bug.
Ademar Reis
Comment 6 2010-09-09 13:50:39 PDT
Revision r67080 cherry-picked into qtwebkit-2.1 with commit 20452c758fb66c9059d5ac540cd4aa0e3ecfab84
Simon Hausmann
Comment 7 2010-09-12 14:08:27 PDT
Revision r67080 cherry-picked into qtwebkit-2.0 with commit c100b313612092308008c160c9dcd3f6238fca24
Note You need to log in before you can comment on or make changes to this bug.