Bug 45268 - [Qt] Symbian scoping in Qt build profile is wrong
Summary: [Qt] Symbian scoping in Qt build profile is wrong
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Major
Assignee: Nobody
Keywords: Qt, QtTriaged
Depends on:
Reported: 2010-09-06 07:51 PDT by Kristian Amlie
Modified: 2010-09-12 14:08 PDT (History)
3 users (show)

See Also:

Patch (1.73 KB, patch)
2010-09-06 07:51 PDT, Kristian Amlie
hausmann: review-
hausmann: commit-queue-
Details | Formatted Diff | Diff
Patch v2 (1.84 KB, patch)
2010-09-09 00:09 PDT, Kristian Amlie
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kristian Amlie 2010-09-06 07:51:38 PDT
Created attachment 66644 [details]

The part in WebCore.pro that refers to missing install functionality is scoped under "symbian", however it should only apply to "symbian-abld" and "symbian-sbsv2".
Comment 1 Simon Hausmann 2010-09-07 08:05:16 PDT
Comment on attachment 66644 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=66644&action=prettypatch

Patch looks okay, but r- because of missing url to bugzilla in the ChangeLog and missing [Qt] as suffix "Fixed incorrect..." should be "[Qt] Fixed incorrect". Could you fix that? :)
Comment 2 Kristian Amlie 2010-09-09 00:09:42 PDT
Created attachment 67001 [details]
Patch v2
Comment 3 Andreas Kling 2010-09-09 04:41:05 PDT
Comment on attachment 67001 [details]
Patch v2

Comment 4 WebKit Commit Bot 2010-09-09 05:05:19 PDT
Comment on attachment 67001 [details]
Patch v2

Clearing flags on attachment: 67001

Committed r67080: <http://trac.webkit.org/changeset/67080>
Comment 5 WebKit Commit Bot 2010-09-09 05:05:24 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Ademar Reis 2010-09-09 13:50:39 PDT
Revision r67080 cherry-picked into qtwebkit-2.1 with commit 20452c758fb66c9059d5ac540cd4aa0e3ecfab84
Comment 7 Simon Hausmann 2010-09-12 14:08:27 PDT
Revision r67080 cherry-picked into qtwebkit-2.0 with commit c100b313612092308008c160c9dcd3f6238fca24