Bug 45263 – Add mediaPlayerPlaybackStateChanged to MediaPlayerClient

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Tor Arne Vestbø]

Add mediaPlayerPlaybackStateChanged to MediaPlayerClient

[Tor Arne Vestbø]

Created attachment 66635 [details]
Patch

[Tor Arne Vestbø]

(In reply to comment #1)
> Created an attachment (id=66635) [details]
> Patch

Tried to keep the logic of updatePlayState() in the refactor, but wondering about if (playerPaused && couldPlayIfEnoughData()), should this check be moved out of the play/not-playing block? Or perhaps be done like this?

 if (!playerPaused)
     m_player->pause();
 
 if (couldPlayIfEnoughData())
     m_player->prepareToPlay();

[Eric Carlson]

Comment on attachment 66635 [details]
Patch

> +        updatePlayState() is then refactored to take into account the
> +        situation where the backend is already in the correct state but
> +        WebCore is not, so that we update thee playback progress timer

Typo - "thee"

>  
> +void HTMLMediaElement::mediaPlayerPlaybackStateChanged(MediaPlayer*)
> +{
> +    beginProcessingMediaPlayerCallback();
> +    if (m_player) {
> +        if (m_player->paused())
> +            pauseInternal();
> +        else
> +            playInternal();
> +    }
> +    endProcessingMediaPlayerCallback();
> +}
> +

Might as well return early if m_player is NULL.


> +            // Set rate before calling play in case the rate was set before the media engine wasn't setup.

Old typo you might as well fix, "wasn't" should be "was".


> Tried to keep the logic of updatePlayState() in the refactor, but wondering about if (playerPaused && 
> couldPlayIfEnoughData()), should this check be moved out of the play/not-playing block? Or perhaps be 
> done like this?
>
> if (!playerPaused)
>     m_player->pause();
>
> if (couldPlayIfEnoughData())
>     m_player->prepareToPlay();

Good idea, this seems much clearer.

Thanks!

r=me

[Tor Arne Vestbø]

Landed in http://trac.webkit.org/changeset/66961

[Ademar Reis]

Revision r66961 cherry-picked into qtwebkit-2.2 with commit b9014dd <http://gitorious.org/webkit/qtwebkit/commit/b9014dd>