Bug 45245 - [Qt] fix uri/escaped-entity.html
Summary: [Qt] fix uri/escaped-entity.html
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: QtWebKit Unassigned
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2010-09-05 14:06 PDT by Robert Hogan
Modified: 2010-09-26 06:12 PDT (History)
3 users (show)

See Also:


Attachments
Patch (4.24 KB, patch)
2010-09-06 11:23 PDT, Robert Hogan
no flags Details | Formatted Diff | Diff
Patch (4.23 KB, patch)
2010-09-26 04:22 PDT, Robert Hogan
no flags Details | Formatted Diff | Diff
Patch (4.23 KB, patch)
2010-09-26 05:58 PDT, Robert Hogan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Hogan 2010-09-05 14:06:06 PDT
Replace invalid encodings with the appropriate escaped entity.

See also http://bugreports.qt.nokia.com/browse/QTBUG-13412
Comment 1 Robert Hogan 2010-09-06 11:23:26 PDT
Created attachment 66661 [details]
Patch
Comment 2 Andreas Kling 2010-09-25 06:38:58 PDT
Comment on attachment 66661 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=66661&action=review

> WebCore/platform/text/qt/TextCodecQt.cpp:137
> +    // FIXME: Until http://bugreports.qt.nokia.com/browse/QTBUG-13412 is resolved we need to this ourselves

Note: It's unlikely that QTBUG-13412 will ever be implemented.

> WebCore/platform/text/qt/TextCodecQt.cpp:146
> +      for (int pos = 0; pos < length; ++pos) {

Sign mismatch, pos should be size_t.

I've discussed this with Olivier Goffart and we feel it's Good Enough(tm).
Please fix the style before committing (tabs should be 4 spaces, not 2.)
Comment 3 Robert Hogan 2010-09-26 04:22:28 PDT
Created attachment 68845 [details]
Patch
Comment 4 Robert Hogan 2010-09-26 05:58:54 PDT
Created attachment 68846 [details]
Patch
Comment 5 WebKit Commit Bot 2010-09-26 06:12:20 PDT
Comment on attachment 68846 [details]
Patch

Clearing flags on attachment: 68846

Committed r68341: <http://trac.webkit.org/changeset/68341>
Comment 6 WebKit Commit Bot 2010-09-26 06:12:26 PDT
All reviewed patches have been landed.  Closing bug.