Bug 45241 – [EFL] REGRESSION(66794) Need to fix build break.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Ryuan Choi]

Implementation of FrameLoaderClient for new feature make build break.

/workspace/WebKit_EFL/WebKit/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp: In member function ‘virtual WTF::PassRefPtr<WebCore::FrameNetworkingContext> WebCore::FrameLoaderClientEfl::createNetworkingContext()’:
/workspace/WebKit_EFL/WebKit/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp:951:12: error: ‘create’ is not a member of ‘WebCore::FrameNetworkingContext’
/workspace/WebKit_EFL/WebKit/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp:951:48: error: ‘m_webFrame’ was not declared in this scope
/workspace/WebKit_EFL/WebKit/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp:951:64: error: ‘core’ was not declared in this scope
make[2]: *** [WebKit/CMakeFiles/ewebkit.dir/efl/WebCoreSupport/FrameLoaderClientEfl.cpp.o] 오류 1
make[2]: *** 끝나지 않은 작업을 기다리고 있습니다....
make[1]: *** [WebKit/CMakeFiles/ewebkit.dir/all] 오류 2
make: *** [all] 오류 2

[Ryuan Choi]

Created attachment 66597 [details]
Patch

[Antonio Gomes]

Comment on attachment 66597 [details]
Patch

It needs a review. Diego what do you think?

[Diego Gonzalez]

(In reply to comment #2)
> (From update of attachment 66597 [details])
> It needs a review. Diego what do you think?

Seems fine!

[Lucas De Marchi]

Comment on attachment 66597 [details]
Patch

> Index: WebKit/efl/ChangeLog
> ===================================================================
> --- WebKit/efl/ChangeLog	(revision 66800)
> +++ WebKit/efl/ChangeLog	(working copy)
> @@ -1,3 +1,20 @@
> [phone]  Ryuan Choi  <[e-mail]>
> +
> +        Unreviewed build fix.
> +
> +        [EFL] REGRESSION(66794) Need to fix build break.
> +        https://bugs.webkit.org/show_bug.cgi?id=45241
> +
> +        Add dummy class(FrameNetworkingContextEfl) like GTK+ port and implement
> +        as EFL style.

Since you copied from GTK, I think you should keep their copyright on WebKit/efl/WebCoreSupport/FrameNetworkingContextEfl.h

[Ryuan Choi]

Created attachment 66646 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 66646 [details]
Patch

Clearing flags on attachment: 66646

Committed r66839: <http://trac.webkit.org/changeset/66839>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.