Bug 45231 – [Qt] Update NetworkAccessManager in Qt FrameNetworkingContext

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Qt

[Diego Gonzalez]

Make possible to get the current QNAM when NetwokingContext request it.

[Diego Gonzalez]

Created attachment 66586 [details]
Patch

[Early Warning System Bot]

Attachment 66586 [details] did not build on qt:
Build output: http://queues.webkit.org/results/3914125

[Kenneth Rohde Christiansen]

This should really build on Qt :)

[Kenneth Rohde Christiansen]

Comment on attachment 66586 [details]
Patch

> From 08ee72aae848a76e1ebd473cde1e5802062653b4 Mon Sep 17 00:00:00 2001
> From: Diego Gonzalez <[e-mail]>
> Date: Sat, 4 Sep 2010 15:12:49 -0400
> Subject: [PATCH] [Qt] Update NetworkAccessManager in Qt FrameNetworkingContext
>  https://bugs.webkit.org/show_bug.cgi?id=45231
> 
> Reviewed by NOBODY (OOPS!).
> 
> Make possible to get the current QNAM when NetwokingContext request it.
> 
> * WebCoreSupport/FrameNetworkingContextQt.cpp:
> (WebCore::FrameNetworkingContextQt::networkAccessManager):
> ---
>  WebKit/qt/ChangeLog                                |   12 ++++++++++++
>  .../qt/WebCoreSupport/FrameNetworkingContextQt.cpp |    4 ++++
>  2 files changed, 16 insertions(+), 0 deletions(-)
> 
> diff --git a/WebKit/qt/ChangeLog b/WebKit/qt/ChangeLog
> index 8f026a2..f5e4e31 100644
> --- a/WebKit/qt/ChangeLog
> +++ b/WebKit/qt/ChangeLog
> @@ -1,3 +1,15 @@
> [phone]  Diego Gonzalez  <[e-mail]>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        [Qt] Update NetworkAccessManager in Qt FrameNetworkingContext
> +        https://bugs.webkit.org/show_bug.cgi?id=45231
> +
> +        Make possible to get the current QNAM when NetwokingContext request it.
> +
> +        * WebCoreSupport/FrameNetworkingContextQt.cpp:
> +        (WebCore::FrameNetworkingContextQt::networkAccessManager):
> +
>  2010-09-03  Jesus Sanchez-Palencia  <[e-mail]>
>  
>          Reviewed by Darin Adler.
> diff --git a/WebKit/qt/WebCoreSupport/FrameNetworkingContextQt.cpp b/WebKit/qt/WebCoreSupport/FrameNetworkingContextQt.cpp
> index e502e2a..98e9f9a 100644
> --- a/WebKit/qt/WebCoreSupport/FrameNetworkingContextQt.cpp
> +++ b/WebKit/qt/WebCoreSupport/FrameNetworkingContextQt.cpp
> @@ -23,6 +23,8 @@
>  
>  #include <QNetworkAccessManager>
>  #include <QObject>
> +#include <QWebFrame>
> +#include <QWebPage>
>  
>  namespace WebCore {
>  
> @@ -45,6 +47,8 @@ QObject* FrameNetworkingContextQt::originatingObject() const
>  
>  QNetworkAccessManager* FrameNetworkingContextQt::networkAccessManager() const
>  {
> +    if (QWebFrame* webFrame = qobject_cast<QWebFrame*>(m_originatingObject))
> +        m_networkAccessManager = webFrame->...

Why not jist return here, and never use m_networkaccessmanager directly?
Just call this method instead.

[Diego Gonzalez]

Created attachment 66645 [details]
Patch

[Antonio Gomes]

Comment on attachment 66645 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 66645 [details]
Patch

Clearing flags on attachment: 66645

Committed r66853: <http://trac.webkit.org/changeset/66853>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Balazs Kelemen]

The m_networkingContext member should be removed according to this change, isn't it?