Bug 45230 – [GTK] When a feature is disabled by default, the source necessary to build it are not included in the distribution

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Martin Robinson]

For features that are disabled by default (such as indexed databases), the sources necessary to build those features are not included in the release distribution. This is because those features are not in the SOURCES primary. Most of these source files are guarded by #ifdefs. We should gradually fix the ones that aren't and move everything to the SOURCES primary.

[Martin Robinson]

Created attachment 66588 [details]
Fix make dist

[Gustavo Noronha (kov)]

Comment on attachment 66588 [details]
Fix make dist

I don't claim to have checked every single line, but it looks sensible to me, it's the build system, and we already discussed this idea on IRC, so I'll say go!

[Martin Robinson]

Since this touches some GStreamer code, I should probably have Philippe double-check my changes there.

[Philippe Normand]

(In reply to comment #3)
> Since this touches some GStreamer code, I should probably have Philippe double-check my changes there.

I am totally fine with the guards added in the gstreamer/ files. Apologies for having forgotten them in the files I created.

[Martin Robinson]

Xan suggested that I split this patch in two, so I'll be posting just the GNUmakefile.am changes shortly.

[Martin Robinson]

Created attachment 66731 [details]
Patch for this issue minus feature guard changes

[Xan Lopez]

Comment on attachment 66731 [details]
Patch for this issue minus feature guard changes

-
-# Clean rules for WebCore
-
-CLEANFILES += \
-	libWebCoreJS.la

This seems an unrelated leftover, everything else looks ok.

[Martin Robinson]

Committed r67392: <http://trac.webkit.org/changeset/67392>