Bug 45229 - GTK Skipped list should allow a directory to be listed when a feature is not supported
Summary: GTK Skipped list should allow a directory to be listed when a feature is not ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-04 11:20 PDT by Steve Block
Modified: 2010-09-04 17:20 PDT (History)
6 users (show)

See Also:


Attachments
Patch (2.19 KB, patch)
2010-09-04 11:22 PDT, Steve Block
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Block 2010-09-04 11:20:11 PDT
Currently, the GTK Skipped list states that all tests should be listed explicitly, without grouping.

We should make an exception for the case when an entire directory of tests is to be skipped due to the feature being unsupported. This eliminates the need to continually update the list when new tests for the feature are added.
Comment 1 Steve Block 2010-09-04 11:22:34 PDT
Created attachment 66585 [details]
Patch
Comment 2 Martin Robinson 2010-09-04 14:11:16 PDT
Comment on attachment 66585 [details]
Patch

LGTM.
Comment 3 WebKit Commit Bot 2010-09-04 16:28:30 PDT
Comment on attachment 66585 [details]
Patch

Clearing flags on attachment: 66585

Committed r66798: <http://trac.webkit.org/changeset/66798>
Comment 4 WebKit Commit Bot 2010-09-04 16:28:34 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 WebKit Review Bot 2010-09-04 17:20:52 PDT
http://trac.webkit.org/changeset/66798 might have broken Qt Linux Release