Bug 45219 - Make SecurityOrigin::canDisplay an instance function
Summary: Make SecurityOrigin::canDisplay an instance function
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-03 17:59 PDT by Adam Barth
Modified: 2010-09-11 19:28 PDT (History)
3 users (show)

See Also:

Attachments
Patch (21.09 KB, patch)
2010-09-03 18:03 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch for landing (22.46 KB, patch)
2010-09-11 17:54 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-09-03 17:59:48 PDT 
Make SecurityOrigin::canDisplay an instance function
Comment 1 Adam Barth 2010-09-03 18:03:22 PDT 
Created attachment 66575 [details]
Patch
Comment 2 Adam Barth 2010-09-10 23:09:57 PDT 
Comment on attachment 66575 [details]
Patch

Thanks for the review.
Comment 3 WebKit Commit Bot 2010-09-10 23:42:59 PDT 
Comment on attachment 66575 [details]
Patch

Rejecting patch 66575 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Sam Weinig', u'--force']" exit_code: 1
Last 500 characters of output:
ginStream.mm
patching file WebKit/mac/Plugins/WebNetscapePluginView.mm
patching file WebKit/mac/Plugins/WebPluginContainerCheck.mm
patching file WebKit/mac/WebView/WebFrame.mm
Hunk #1 succeeded at 1265 (offset -17 lines).
patching file WebKit/win/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebKit/win/WebFrame.cpp
Hunk #1 succeeded at 1345 (offset -7 lines).
patching file WebKit2/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebKit2/WebProcess/Plugins/PluginView.cpp

Full output: http://queues.webkit.org/results/3906390
Comment 4 Adam Barth 2010-09-11 17:54:56 PDT 
Created attachment 67320 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2010-09-11 19:28:36 PDT 
Comment on attachment 67320 [details]
Patch for landing

Clearing flags on attachment: 67320

Committed r67316: <http://trac.webkit.org/changeset/67316>
Comment 6 WebKit Commit Bot 2010-09-11 19:28:41 PDT 
All reviewed patches have been landed.  Closing bug.