WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
45211
Add AudioDSPKernelProcessor files
https://bugs.webkit.org/show_bug.cgi?id=45211
Summary
Add AudioDSPKernelProcessor files
Chris Rogers
Reported
2010-09-03 15:55:57 PDT
Add AudioDSPKernelProcessor files
Attachments
Patch
(8.42 KB, patch)
2010-09-03 15:57 PDT
,
Chris Rogers
no flags
Details
Formatted Diff
Diff
Patch
(8.44 KB, patch)
2010-09-07 13:36 PDT
,
Chris Rogers
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Chris Rogers
Comment 1
2010-09-03 15:57:49 PDT
Created
attachment 66561
[details]
Patch
Chris Rogers
Comment 2
2010-09-07 13:36:41 PDT
Created
attachment 66758
[details]
Patch
Kenneth Russell
Comment 3
2010-09-09 14:32:21 PDT
Comment on
attachment 66758
[details]
Patch Looks fine to me. I hope that the JavaScript code which drives some of these classes can't trigger the assertions throughout this code simply by reconfiguring the audio graph, and that the assertions firing would imply a bug in the audio engine itself.
Chris Rogers
Comment 4
2010-09-09 14:55:14 PDT
Ken, all assertions are meant to catch bugs in the actual code. Exceptions will be used for anything bad which JavaScript code could itself possibly trigger.
WebKit Commit Bot
Comment 5
2010-09-09 15:48:46 PDT
Comment on
attachment 66758
[details]
Patch Clearing flags on attachment: 66758 Committed
r67121
: <
http://trac.webkit.org/changeset/67121
>
WebKit Commit Bot
Comment 6
2010-09-09 15:48:51 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug