Bug 45211 - Add AudioDSPKernelProcessor files
Summary: Add AudioDSPKernelProcessor files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-03 15:55 PDT by Chris Rogers
Modified: 2010-09-09 15:48 PDT (History)
8 users (show)

See Also:

Attachments
Patch (8.42 KB, patch)
2010-09-03 15:57 PDT, Chris Rogers 		no flags Details | Formatted Diff | Diff
Patch (8.44 KB, patch)
2010-09-07 13:36 PDT, Chris Rogers 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Rogers 2010-09-03 15:55:57 PDT 
Add AudioDSPKernelProcessor files
Comment 1 Chris Rogers 2010-09-03 15:57:49 PDT 
Created attachment 66561 [details]
Patch
Comment 2 Chris Rogers 2010-09-07 13:36:41 PDT 
Created attachment 66758 [details]
Patch
Comment 3 Kenneth Russell 2010-09-09 14:32:21 PDT 
Comment on attachment 66758 [details]
Patch

Looks fine to me. I hope that the JavaScript code which drives some of these classes can't trigger the assertions throughout this code simply by reconfiguring the audio graph, and that the assertions firing would imply a bug in the audio engine itself.
Comment 4 Chris Rogers 2010-09-09 14:55:14 PDT 
Ken, all assertions are meant to catch bugs in the actual code.  Exceptions will be used for anything bad which JavaScript code could itself possibly trigger.
Comment 5 WebKit Commit Bot 2010-09-09 15:48:46 PDT 
Comment on attachment 66758 [details]
Patch

Clearing flags on attachment: 66758

Committed r67121: <http://trac.webkit.org/changeset/67121>
Comment 6 WebKit Commit Bot 2010-09-09 15:48:51 PDT 
All reviewed patches have been landed.  Closing bug.