RESOLVED FIXED 45207
[chromium] Implement ImageBufferSkia::draw on the GPU when possible 
https://bugs.webkit.org/show_bug.cgi?id=45207
Summary [chromium] Implement ImageBufferSkia::draw on the GPU when possible
James Robinson
Reported 2010-09-03 15:35:22 PDT
[chromium] Implement ImageBufferSkia::draw on the GPU when possible
Attachments
Patch (6.05 KB, patch)
2010-09-03 15:43 PDT, James Robinson 		no flags
DetailsFormatted DiffDiff
Patch (5.35 KB, patch)
2010-09-03 17:36 PDT, James Robinson 		no flags
DetailsFormatted DiffDiff
adds a check that the source canvas is 2d before going down the accelerated path (5.57 KB, patch)
2010-09-03 17:50 PDT, James Robinson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2010-09-03 15:43:31 PDT
Created attachment 66560 [details] Patch
Kenneth Russell
Comment 2 2010-09-03 17:32:03 PDT
Comment on attachment 66560 [details] Patch We've discussed this offline, but in the multisampling case you definitely do not want to reallocate the color texture into which the blit occurs each frame, so releaseBackingTexture() is unneeded. Also, getBackingTexture() needs to be called each time we want to display the up-to-date content in the multisampling case, so it should probably be named getUpToDateBackingTexture() or similar.
James Robinson
Comment 3 2010-09-03 17:36:50 PDT
Created attachment 66572 [details] Patch
James Robinson
Comment 4 2010-09-03 17:38:29 PDT
Good point. Removed the release..() function and renamed the getter getRenderingResultsAsTexture(), which hopefully conveys that the returned texture gets the current rendering results.
Kenneth Russell
Comment 5 2010-09-03 17:44:37 PDT
Comment on attachment 66572 [details] Patch This looks better but I noticed one more thing; sorry. View in context: https://bugs.webkit.org/attachment.cgi?id=66572&action=prettypatch > WebCore/html/canvas/CanvasRenderingContext2D.cpp:1286 > + if (!isAccelerated() || !sourceContext || !sourceContext->isAccelerated()) For the time being, this needs a more specific check to make sure the source context is 2D. This won't work for the WebGL code path right now.
James Robinson
Comment 6 2010-09-03 17:50:49 PDT
Created attachment 66573 [details] adds a check that the source canvas is 2d before going down the accelerated path
Kenneth Russell
Comment 7 2010-09-03 18:05:38 PDT
Comment on attachment 66573 [details] adds a check that the source canvas is 2d before going down the accelerated path Looks good to me.
James Robinson
Comment 8 2010-09-07 17:40:41 PDT
Landed at r66785 with a slightly-mismerged ChangeLog.
James Robinson
Comment 9 2010-09-07 17:41:21 PDT
Comment on attachment 66573 [details] adds a check that the source canvas is 2d before going down the accelerated path Clearing flags, patch has landed.
Note You need to log in before you can comment on or make changes to this bug.