Bug 45204 - Add AudioArray.h
Summary: Add AudioArray.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-03 14:49 PDT by Chris Rogers
Modified: 2010-09-07 17:48 PDT (History)
7 users (show)

See Also:

Attachments
Patch (3.53 KB, patch)
2010-09-03 14:50 PDT, Chris Rogers 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Rogers 2010-09-03 14:49:28 PDT 
Add AudioArray.h
Comment 1 Chris Rogers 2010-09-03 14:50:42 PDT 
Created attachment 66547 [details]
Patch
Comment 2 Kenneth Russell 2010-09-07 17:30:22 PDT 
Comment on attachment 66547 [details]
Patch

Looks good to me. One comment not necessarily requiring action.

View in context: https://bugs.webkit.org/attachment.cgi?id=66547&action=prettypatch

> WebCore/platform/audio/AudioArray.h:55
> +    void copyToRange(T* sourceData, unsigned start, unsigned end)
If you have situations elsewhere in your code where you would pass e.g. AudioFloatArray.data() as the first argument to copyToRange, then it would be good to add another overloaded version of copyToRange which can also verify that the source array has enough elements to cover the copy operation.
Comment 3 Chris Rogers 2010-09-07 17:48:37 PDT 
Comment on attachment 66547 [details]
Patch

Clearing flags on attachment: 66547

Committed r66938: <http://trac.webkit.org/changeset/66938>
Comment 4 Chris Rogers 2010-09-07 17:48:43 PDT 
All reviewed patches have been landed.  Closing bug.