Bug 45196 - [Chromium] Make sure that the width of the menu list is always constant under layout tests.
Summary: [Chromium] Make sure that the width of the menu list is always constant under...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Dimitri Glazkov (Google)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-03 13:25 PDT by Dimitri Glazkov (Google)
Modified: 2010-09-04 00:18 PDT (History)
5 users (show)

See Also:


Attachments
Patch (12.72 KB, patch)
2010-09-03 13:28 PDT, Dimitri Glazkov (Google)
no flags Details | Formatted Diff | Diff
Now with correct test expectations. (8.13 KB, patch)
2010-09-03 13:35 PDT, Dimitri Glazkov (Google)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2010-09-03 13:25:42 PDT
[Chromium] Make sure that the width of the menu list is always constant under layout tests.
Comment 1 Dimitri Glazkov (Google) 2010-09-03 13:28:13 PDT
Created attachment 66537 [details]
Patch
Comment 2 Dimitri Glazkov (Google) 2010-09-03 13:35:28 PDT
Created attachment 66538 [details]
Now with correct test expectations.
Comment 3 Tony Chang 2010-09-03 13:37:53 PDT
Comment on attachment 66538 [details]
Now with correct test expectations.

Why doesn't test_shell have this problem?
Comment 4 Dimitri Glazkov (Google) 2010-09-03 13:41:20 PDT
It should, if you muck with themes -- this is not a DRT-only issue. I just happened to have a Win 7 theme different from that on the test box and noticed this.
Comment 5 Dimitri Glazkov (Google) 2010-09-03 13:43:10 PDT
Comment on attachment 66538 [details]
Now with correct test expectations.

Clearing flags on attachment: 66538

Committed r66768: <http://trac.webkit.org/changeset/66768>
Comment 6 Dimitri Glazkov (Google) 2010-09-03 13:43:15 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 WebKit Review Bot 2010-09-04 00:18:44 PDT
http://trac.webkit.org/changeset/66768 might have broken Leopard Intel Debug (Tests)
The following changes are on the blame list:
http://trac.webkit.org/changeset/66768
http://trac.webkit.org/changeset/66767