RESOLVED FIXED 45172
Web Inspector: cleanup inspector api. getChildNodes should return children nodes as an output value. 
https://bugs.webkit.org/show_bug.cgi?id=45172
Summary Web Inspector: cleanup inspector api. getChildNodes should return children no...
Ilya Tikhonovsky
Reported 2010-09-03 06:36:05 PDT
current implementation of the inspector api has some unnecessary complexity. As example WebInspector is requesting children nodes of a node by getChildNodes but DOM agent is actually pushing the child nodes via setChildNodes event call and send back an empty response message.
Attachments
[patch] initial version. (7.12 KB, patch)
2010-09-03 06:48 PDT, Ilya Tikhonovsky 		pfeldman: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1 2010-09-03 06:48:57 PDT
Created attachment 66488 [details] [patch] initial version.
WebKit Commit Bot
Comment 2 2010-09-03 08:18:08 PDT
Comment on attachment 66488 [details] [patch] initial version. Clearing flags on attachment: 66488 Committed r66732: <http://trac.webkit.org/changeset/66732>
WebKit Commit Bot
Comment 3 2010-09-03 08:18:12 PDT
All reviewed patches have been landed. Closing bug.
Pavel Feldman
Comment 4 2010-09-03 10:58:07 PDT
Comment on attachment 66488 [details] [patch] initial version. I don't think it is good idea and would vote to rolling this back. It is important that all the information is pushed to the DOMAgent.js by means of the same pushChildren method. Otherwise DOMAgent.js and InspectorDOMAgent may get easily our of sync. I do realize that API needs to be brushed up, but I'd start with pushDocument refactorings so that there is no DOM-related traffic unless requested.
Note You need to log in before you can comment on or make changes to this bug.