Bug 45161 – Add unit tests for interval tree

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Kenneth Russell]

The interval tree being integrated in https://bugs.webkit.org/show_bug.cgi?id=45160 needs unit tests integrated as well.

[Kenneth Russell]

Created attachment 66465 [details]
Patch

This patch won't build until bug 45060 and bug 45160 land, but it should give reviewers an idea of how the tree has been tested.

[WebKit Review Bot]

Attachment 66465 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/3924063

[Darin Fisher (:fishd, Google)]

Comment on attachment 66465 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=66465&action=prettypatch

> WebKit/chromium/tests/PODIntervalTreeTest.cpp:109
> +namespace {
nit: add new line after "namespace {" to match the new line above the closing bracket

> WebKit/chromium/tests/PODIntervalTreeTest.cpp:150
> +namespace {
nit: add new line below this line

> WebKit/chromium/tests/PODIntervalTreeTest.cpp:199
> +        int len = nextRandom(maximumValue);
nit: len -> length

> WebKit/chromium/tests/PODIntervalTreeTest.cpp:210
> +        int idx = nextRandom(addedElements.size());
nit: idx -> index

R=me w/ those nits fixed

[Kenneth Russell]

Committed r66809: <http://trac.webkit.org/changeset/66809>

[WebKit Review Bot]

http://trac.webkit.org/changeset/66809 might have broken Leopard Intel Debug (Tests)