Modify webcore project files to include V8 javascript engine. By default disabled.
Created attachment 66433 [details] webcore project files changes
1./ Instead of +contains(QTJAVASCRIPTENGINE, V8) { + WEBCORE_INCLUDEPATH = \ + $$PWD/../v8.$$QTJAVASCRIPTENGINEREV/include \ + $$PWD/bindings/v8 \ I would recommend +contains(QTJAVASCRIPTENGINE, V8) { + WEBCORE_INCLUDEPATH = \ + $$PWD/../$$V8_DIR/include \ + $$PWD/bindigs/v8 2./ Instead of repeating the wtf source files in WebCore.pro I think it is time to create a wtf.pri under JavaScriptCore/wtf.
Comment on attachment 66433 [details] webcore project files changes View in context: https://bugs.webkit.org/attachment.cgi?id=66433&action=prettypatch > WebCore/WebCore.pri:70 > +contains(QTJAVASCRIPTENGINE, V8) { > + IDL_BINDINGS += \ > + html/canvas/CanvasPixelArray.idl > +} > + Andreas, do we need this for the JSC build, too?
(In reply to comment #3) > > WebCore/WebCore.pri:70 > > +contains(QTJAVASCRIPTENGINE, V8) { > > + IDL_BINDINGS += \ > > + html/canvas/CanvasPixelArray.idl > > +} > > + > Andreas, do we need this for the JSC build, too? No, JSC returns a manually constructed CanvasPixelArray object in WebCore/bindings/js/JSImageDataCustom.cpp and does not use this IDL file.
Created attachment 66520 [details] QTJAVASCRIPTENGINE changed to JAVASCRIPT_ENGINE. Added V8_INCLUDE_DIR
Comment on attachment 66520 [details] QTJAVASCRIPTENGINE changed to JAVASCRIPT_ENGINE. Added V8_INCLUDE_DIR > + platform/qt/platformBridge.cpp \ This won't work on case-sensitive systems; the file you added in another patch was called "PlatformBridge.cpp"
Created attachment 67304 [details] Patch
Created attachment 67305 [details] Patch
Created attachment 67306 [details] Patch
Created attachment 67307 [details] Patch
Created attachment 67308 [details] Patch
Comment on attachment 67308 [details] Patch r=me
Committed r67306: <http://trac.webkit.org/changeset/67306>