Bug 45141 - [Qt] V8 port for QT platform: webcore project files changes
: [Qt] V8 port for QT platform: webcore project files changes
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: New Bugs
: 528+ (Nightly build)
: All All
: P3 Normal
Assigned To: QtWebKit Unassigned
: Qt, QtTriaged
Depends on:
Blocks: 45136
  Show dependency treegraph
 
Reported: 2010-09-02 15:45 PDT by Vlad
Modified: 2010-09-11 11:13 PDT (History)
4 users (show)

See Also:


Attachments
webcore project files changes (51.53 KB, text/plain)
2010-09-02 17:09 PDT, Vlad
no flags Details
QTJAVASCRIPTENGINE changed to JAVASCRIPT_ENGINE. Added V8_INCLUDE_DIR (51.85 KB, patch)
2010-09-03 10:52 PDT, Vlad
no flags Details | Formatted Diff | Diff
Patch (52.03 KB, patch)
2010-09-11 10:53 PDT, Simon Hausmann
no flags Details | Formatted Diff | Diff
Patch (52.03 KB, patch)
2010-09-11 10:55 PDT, Simon Hausmann
no flags Details | Formatted Diff | Diff
Patch (1.52 KB, patch)
2010-09-11 11:00 PDT, Simon Hausmann
no flags Details | Formatted Diff | Diff
Patch (2.26 KB, patch)
2010-09-11 11:02 PDT, Simon Hausmann
no flags Details | Formatted Diff | Diff
Patch (51.99 KB, patch)
2010-09-11 11:07 PDT, Simon Hausmann
akling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vlad 2010-09-02 15:45:20 PDT
Modify webcore project files to include V8 javascript engine. By default disabled.
Comment 1 Vlad 2010-09-02 17:09:51 PDT
Created attachment 66433 [details]
webcore project files changes
Comment 2 Laszlo Gombos 2010-09-02 19:47:53 PDT
1./ Instead of 

+contains(QTJAVASCRIPTENGINE, V8) {
+    WEBCORE_INCLUDEPATH = \
+        $$PWD/../v8.$$QTJAVASCRIPTENGINEREV/include \
+        $$PWD/bindings/v8 \

I would recommend 

+contains(QTJAVASCRIPTENGINE, V8) {
+    WEBCORE_INCLUDEPATH = \
+        $$PWD/../$$V8_DIR/include \
+        $$PWD/bindigs/v8

2./ Instead of repeating the wtf source files in WebCore.pro I think it is time to create a wtf.pri under JavaScriptCore/wtf.
Comment 3 Simon Hausmann 2010-09-02 23:53:16 PDT
Comment on attachment 66433 [details]
webcore project files changes

View in context: https://bugs.webkit.org/attachment.cgi?id=66433&action=prettypatch

> WebCore/WebCore.pri:70
> +contains(QTJAVASCRIPTENGINE, V8) {
> +    IDL_BINDINGS += \
> +        html/canvas/CanvasPixelArray.idl
> +}
> +
Andreas, do we need this for the JSC build, too?
Comment 4 Andreas Kling 2010-09-03 01:59:24 PDT
(In reply to comment #3)
> > WebCore/WebCore.pri:70
> > +contains(QTJAVASCRIPTENGINE, V8) {
> > +    IDL_BINDINGS += \
> > +        html/canvas/CanvasPixelArray.idl
> > +}
> > +
> Andreas, do we need this for the JSC build, too?

No, JSC returns a manually constructed CanvasPixelArray object in WebCore/bindings/js/JSImageDataCustom.cpp and does not use this IDL file.
Comment 5 Vlad 2010-09-03 10:52:39 PDT
Created attachment 66520 [details]
QTJAVASCRIPTENGINE changed to JAVASCRIPT_ENGINE. Added V8_INCLUDE_DIR
Comment 6 Andreas Kling 2010-09-07 08:40:46 PDT
Comment on attachment 66520 [details]
QTJAVASCRIPTENGINE changed to JAVASCRIPT_ENGINE. Added V8_INCLUDE_DIR

> +       platform/qt/platformBridge.cpp \

This won't work on case-sensitive systems; the file you added in another patch was called "PlatformBridge.cpp"
Comment 7 Simon Hausmann 2010-09-11 10:53:53 PDT
Created attachment 67304 [details]
Patch
Comment 8 Simon Hausmann 2010-09-11 10:55:19 PDT
Created attachment 67305 [details]
Patch
Comment 9 Simon Hausmann 2010-09-11 11:00:36 PDT
Created attachment 67306 [details]
Patch
Comment 10 Simon Hausmann 2010-09-11 11:02:47 PDT
Created attachment 67307 [details]
Patch
Comment 11 Simon Hausmann 2010-09-11 11:07:56 PDT
Created attachment 67308 [details]
Patch
Comment 12 Andreas Kling 2010-09-11 11:08:51 PDT
Comment on attachment 67308 [details]
Patch

r=me
Comment 13 Simon Hausmann 2010-09-11 11:13:17 PDT
Committed r67306: <http://trac.webkit.org/changeset/67306>