Hi, after building webkit-gtk, a few .po~ files are reported as untracked by git status file WebKit/gtk/po/webkit-2.0.pot is also reported as untracked by git status
Created attachment 66409 [details] patch v1
If possible it would be great to get these to generate in the build directory.
I can't find how those .po~ are created I think that must be in WebKit/gtk/po/GNUmakefile.am but which command create them ?
I've CC'd Alex, who has done some work with the po files in the past.
Two ideas: why not ignore all *~ files, given those are usually generated by popular editors such as Emacs? Also, we should ignore WebKit/gtk/po/*.pot, because the name of the pot file may change depending on the version of the library that is being build (with gtk2 or 3)
(In reply to comment #5) > Two ideas: why not ignore all *~ files, given those are usually generated by popular editors such as Emacs? I think this is a great idea. > Also, we should ignore WebKit/gtk/po/*.pot, because the name of the pot file may change depending on the version of the library that is being build (with gtk2 or 3) Agree with this as well, though I believe we can get it to generate in WebKitBuild still. For now I think it's probably fine to ignore it where it is.
Created attachment 66666 [details] patch v1.1 (In reply to comment #5) > Two ideas: why not ignore all *~ files, given those are usually generated by popular editors such as Emacs? Also, we should ignore WebKit/gtk/po/*.pot, because the name of the pot file may change depending on the version of the library that is being build (with gtk2 or 3) Should we ignore *~ globally or just for gtk ? here is an updated patch ignoring *~ globally.
Comment on attachment 66666 [details] patch v1.1 Looks good. Nice patch number.
Comment on attachment 66666 [details] patch v1.1 Clearing flags on attachment: 66666 Committed r66870: <http://trac.webkit.org/changeset/66870>
All reviewed patches have been landed. Closing bug.