Bug 45123 - Markup.waitUntilDone does not call Markup.noAutoDump without LayoutTestController
Summary: Markup.waitUntilDone does not call Markup.noAutoDump without LayoutTestContro...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-02 12:52 PDT by Ryosuke Niwa
Modified: 2010-09-07 18:27 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.12 KB, patch)
2010-09-07 17:58 PDT, Ojan Vafai
tkent: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2010-09-02 12:52:32 PDT
At dump-as-markup.js#L90 we have:
Markup.waitUntilDone = function()
{
    layoutTestController.waitUntilDone();
    Markup.noAutoDump();
}

But if layoutTestController was undefined, we would error at L92 and will never call noAutoDump().
Comment 1 Ojan Vafai 2010-09-07 17:58:09 PDT
Created attachment 66810 [details]
Patch
Comment 2 Ojan Vafai 2010-09-07 18:27:05 PDT
Committed r66944: <http://trac.webkit.org/changeset/66944>