Bug 45122 - [EFL] Fix double addition of -fPIC
Summary: [EFL] Fix double addition of -fPIC
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Lucas De Marchi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-02 12:33 PDT by Lucas De Marchi
Modified: 2010-09-02 22:42 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.11 KB, patch)
2010-09-02 12:45 PDT, Lucas De Marchi 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas De Marchi 2010-09-02 12:33:37 PDT 
[EFL] Fix double addition of -fPIC
Comment 1 Lucas De Marchi 2010-09-02 12:45:02 PDT 
Created attachment 66399 [details]
Patch
Comment 2 Antonio Gomes 2010-09-02 14:29:11 PDT 
Comment on attachment 66399 [details]
Patch

* cmake/WebKitHelpers.cmake: Add -fPIC flags iff SHARED_CORE=ON.


"iff" :#
Comment 3 Lucas De Marchi 2010-09-02 15:21:09 PDT 
(In reply to comment #2)
> (From update of attachment 66399 [details])
> * cmake/WebKitHelpers.cmake: Add -fPIC flags iff SHARED_CORE=ON.
> 
> 
> "iff" :#

It was intentional, meaning "if and only if". Setting cq+.
Comment 4 WebKit Commit Bot 2010-09-02 22:42:04 PDT 
Comment on attachment 66399 [details]
Patch

Clearing flags on attachment: 66399

Committed r66714: <http://trac.webkit.org/changeset/66714>
Comment 5 WebKit Commit Bot 2010-09-02 22:42:08 PDT 
All reviewed patches have been landed.  Closing bug.