WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 45117
Add WKMutableDictionary API for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=45117
Summary
Add WKMutableDictionary API for WebKit2
Sam Weinig
Reported
2010-09-02 11:15:06 PDT
Add WKMutableDictionary API for WebKit2
Attachments
Patch
(23.89 KB, patch)
2010-09-02 11:17 PDT
,
Sam Weinig
andersca
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Sam Weinig
Comment 1
2010-09-02 11:17:29 PDT
Created
attachment 66388
[details]
Patch
WebKit Review Bot
Comment 2
2010-09-02 11:20:19 PDT
Attachment 66388
[details]
did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit2/Shared/MutableDictionary.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit2/UIProcess/API/C/WKAPICast.h:73: More than one command on the same line [whitespace/newline] [4] WebKit2/UIProcess/API/C/WKAPICast.h:90: More than one command on the same line [whitespace/newline] [4] WebKit2/UIProcess/API/C/WKMutableDictionary.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 4 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
Eric Seidel (no email)
Comment 3
2010-10-13 12:27:08 PDT
Attachment 66388
[details]
was posted by a committer and has review+, assigning to Sam Weinig for commit.
Sam Weinig
Comment 4
2010-10-28 13:18:31 PDT
Landed in
http://trac.webkit.org/changeset/66676
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug