Test added in http://trac.webkit.org/changeset/66646/ fails for Chromium. Diff is: --- /b/slave/webkit-rel-mac-webkit-org/build/src/webkit/Release/../../../layout-test-results/media/media-can-play-mpeg4-video-expected.txt +++ /b/slave/webkit-rel-mac-webkit-org/build/src/webkit/Release/../../../layout-test-results/media/media-can-play-mpeg4-video-actual.txt @@ -1,5 +1,5 @@ Test HTMLMediaElement canPlayType() method with multiple video mpeg4 MIME types. -EXPECTED (video.canPlayType('video/x-m4v') == 'maybe') OK -EXPECTED (video.canPlayType('video/mp4') == 'maybe') OK +EXPECTED (video.canPlayType('video/x-m4v') == 'maybe'), OBSERVED '' FAIL +EXPECTED (video.canPlayType('video/mp4') == 'maybe'), OBSERVED '' FAIL END OF TEST (see also http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&useWebKitCanary=true&tests=media%2Fmedia-can-play-mpeg4-video.html) Apparently it's a genuine failure and I shouldn't just rebaseline expectations.
Can it be skipped then?
(In reply to comment #1) > Can it be skipped then? That's precisely what I do for now, but ideally we'd have it resolved. BTW, if you think the diff is fine, I'll just rebaseline.
(In reply to comment #2) > (In reply to comment #1) > > Can it be skipped then? > > That's precisely what I do for now, but ideally we'd have it resolved. > > BTW, if you think the diff is fine, I'll just rebaseline. Well you should return something i think. Be it "maybe" or "probably". Thanks for skipping it anyway.
this is expected as the Chromium port only supports Ogg+Theora/Vorbis and WebM+VP8/Vorbis this test explicitly checks for support for a format that Chromium doesn't support -- so it's safe to mark as SKIP there's already a section in test_expectations.txt for tests like these (look for some media tests marked as SKIP with a comment that explains the situation)
Created attachment 67064 [details] Patch
Comment on attachment 67064 [details] Patch Clearing flags on attachment: 67064 Committed r67192: <http://trac.webkit.org/changeset/67192>
All reviewed patches have been landed. Closing bug.
Thanks a lot, Kent and Andrew.