Bug 45102 – [Chromium] media/media-can-play-mpeg4-video.html fails under Chromium

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[anton muhin]

Test added in http://trac.webkit.org/changeset/66646/ fails for Chromium.  Diff is:

--- /b/slave/webkit-rel-mac-webkit-org/build/src/webkit/Release/../../../layout-test-results/media/media-can-play-mpeg4-video-expected.txt 
+++ /b/slave/webkit-rel-mac-webkit-org/build/src/webkit/Release/../../../layout-test-results/media/media-can-play-mpeg4-video-actual.txt 
@@ -1,5 +1,5 @@
 Test HTMLMediaElement canPlayType() method with multiple video mpeg4 MIME types.
 
-EXPECTED (video.canPlayType('video/x-m4v') == 'maybe') OK
-EXPECTED (video.canPlayType('video/mp4') == 'maybe') OK
+EXPECTED (video.canPlayType('video/x-m4v') == 'maybe'), OBSERVED '' FAIL
+EXPECTED (video.canPlayType('video/mp4') == 'maybe'), OBSERVED '' FAIL
 END OF TEST

(see also http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&useWebKitCanary=true&tests=media%2Fmedia-can-play-mpeg4-video.html)

Apparently it's a genuine failure and I shouldn't just rebaseline expectations.

[Philippe Normand]

Can it be skipped then?

[anton muhin]

(In reply to comment #1)
> Can it be skipped then?

That's precisely what I do for now, but ideally we'd have it resolved.

BTW, if you think the diff is fine, I'll just rebaseline.

[Philippe Normand]

(In reply to comment #2)
> (In reply to comment #1)
> > Can it be skipped then?
> 
> That's precisely what I do for now, but ideally we'd have it resolved.
> 
> BTW, if you think the diff is fine, I'll just rebaseline.

Well you should return something i think. Be it "maybe" or "probably".

Thanks for skipping it anyway.

[Andrew Scherkus]

this is expected as the Chromium port only supports Ogg+Theora/Vorbis and WebM+VP8/Vorbis

this test explicitly checks for support for a format that Chromium doesn't support -- so it's safe to mark as SKIP

there's already a section in test_expectations.txt for tests like these (look for some media tests marked as SKIP with a comment that explains the situation)

[anton muhin]

Created attachment 67064 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 67064 [details]
Patch

Clearing flags on attachment: 67064

Committed r67192: <http://trac.webkit.org/changeset/67192>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[anton muhin]

Thanks a lot, Kent and Andrew.