Bug 45082 - Add mutable array API to WebKit2
Summary: Add mutable array API to WebKit2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-01 19:16 PDT by Sam Weinig
Modified: 2010-09-02 03:20 PDT (History)
3 users (show)

See Also:


Attachments
Patch (22.43 KB, patch)
2010-09-01 19:21 PDT, Sam Weinig
aroben: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2010-09-01 19:16:32 PDT
Add mutable array API to WebKit2
Comment 1 Sam Weinig 2010-09-01 19:21:25 PDT
Created attachment 66313 [details]
Patch
Comment 2 WebKit Review Bot 2010-09-01 19:27:16 PDT
Attachment 66313 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/UIProcess/API/C/WKAPICast.h:71:  More than one command on the same line  [whitespace/newline] [4]
WebKit2/UIProcess/API/C/WKAPICast.h:77:  More than one command on the same line  [whitespace/newline] [4]
WebKit2/UIProcess/API/C/WKAPICast.h:87:  More than one command on the same line  [whitespace/newline] [4]
WebKit2/UIProcess/API/C/WKMutableArray.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit2/Shared/MutableArray.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 5 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Adam Roben (:aroben) 2010-09-01 20:37:00 PDT
Comment on attachment 66313 [details]
Patch

A comment giving an example of how the toWK function works would be great.

r=me
Comment 4 Sam Weinig 2010-09-01 20:37:49 PDT
Landed in r66638.
Comment 5 WebKit Review Bot 2010-09-02 03:20:37 PDT
http://trac.webkit.org/changeset/66638 might have broken SnowLeopard Intel Release (Tests)