Add Panner files
Created attachment 66306 [details] Patch
Comment on attachment 66306 [details] Patch Basically looks fine; one nit. Feel free to fix before commit if committing with webkit-patch land, or upload a new patch. > Index: WebCore/platform/audio/Panner.h > =================================================================== > --- WebCore/platform/audio/Panner.h (revision 0) > +++ WebCore/platform/audio/Panner.h (revision 0) > @@ -0,0 +1,69 @@ > +/* > + * Copyright (C) 2009 Google Inc. All rights reserved. > + * > + * Redistribution and use in source and binary forms, with or without > + * modification, are permitted provided that the following conditions > + * are met: > + * > + * 1. Redistributions of source code must retain the above copyright > + * notice, this list of conditions and the following disclaimer. > + * 2. Redistributions in binary form must reproduce the above copyright > + * notice, this list of conditions and the following disclaimer in the > + * documentation and/or other materials provided with the distribution. > + * 3. Neither the name of Apple Computer, Inc. ("Apple") nor the names of > + * its contributors may be used to endorse or promote products derived > + * from this software without specific prior written permission. > + * > + * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY > + * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED > + * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE > + * DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY > + * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES > + * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; > + * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND > + * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT > + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF > + * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > + */ > + > +#ifndef Panner_h > +#define Panner_h > + > +#include <wtf/PassOwnPtr.h> > + > +namespace WebCore { > + > +class AudioBus; > + > +// Abstract base class for panning a mono or stereo source. > + > +class Panner { > +public: > + enum { > + PanningModelPassthrough = 0, > + PanningModelEqualPower = 1, > + PanningModelHRTF = 2, > + PanningModelSoundField = 3 > + }; > + > + typedef unsigned PanningModel; Just use "enum PanningModel" and get rid of the typedef. > + > + static PassOwnPtr<Panner> create(PanningModel model, double sampleRate); > + > + virtual ~Panner() { }; > + > + PanningModel panningModel() const { return m_panningModel; } > + > + virtual void pan(double azimuth, double elevation, AudioBus* inputBus, AudioBus* outputBus, size_t framesToProcess) = 0; > + > + virtual void reset() = 0; > + > +protected: > + Panner(PanningModel model) : m_panningModel(model) { } > + > + PanningModel m_panningModel; > +}; > + > +} // namespace WebCore > + > +#endif // Panner_h
Comment on attachment 66306 [details] Patch Rejecting patch 66306 from commit-queue. crogers@google.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
Comment on attachment 66306 [details] Patch Clearing flags on attachment: 66306 Committed r66753: <http://trac.webkit.org/changeset/66753>
All reviewed patches have been landed. Closing bug.