Bug 45068 - REGRESSION(r66431): WebCore::Editor::selectionStartCSSPropertyValue crashes if no background color is specified
Summary: REGRESSION(r66431): WebCore::Editor::selectionStartCSSPropertyValue crashes i...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P1 Critical
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-01 15:53 PDT by Ryosuke Niwa
Modified: 2010-09-01 16:19 PDT (History)
4 users (show)

See Also:


Attachments
Patch (4.10 KB, patch)
2010-09-01 16:06 PDT, Ryosuke Niwa
dglazkov: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2010-09-01 15:53:45 PDT
When there is no background color specified in any ancestor, execCommand('backColor') crashes WebKit.
This is a regression from r66431 and major blocking bug for Chromium dev release.  It affects hotmail.com and should be fixed promptly.

http://crbug.com/54155
Comment 1 Ryosuke Niwa 2010-09-01 16:06:35 PDT
Created attachment 66297 [details]
Patch
Comment 2 Ryosuke Niwa 2010-09-01 16:07:28 PDT
Very embarrassing regression. The loop was missing a null check.
Comment 3 Dimitri Glazkov (Google) 2010-09-01 16:10:00 PDT
Comment on attachment 66297 [details]
Patch

ok.
Comment 4 Ryosuke Niwa 2010-09-01 16:19:03 PDT
Committed r66624: <http://trac.webkit.org/changeset/66624>