Bug 45067 - test failure: inspector/console-format.html
Summary: test failure: inspector/console-format.html
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-01 15:48 PDT by Matthew Willis (lilmatt)
Modified: 2010-09-01 16:27 PDT (History)
11 users (show)

See Also:

Attachments
Fix failing test (1.81 KB, patch)
2010-09-01 15:57 PDT, Matthew Willis (lilmatt) 		joepeck: review+
joepeck: commit-queue+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Willis (lilmatt) 2010-09-01 15:48:36 PDT 
The test 'inspector/console-format.html' is failing.  This is fallout from svn revision 66616.
Comment 1 Matthew Willis (lilmatt) 2010-09-01 15:57:52 PDT 
Created attachment 66295 [details]
Fix failing test

Fixes failing test caused by r66616
Comment 2 Joseph Pecoraro 2010-09-01 16:00:33 PDT 
The diff shows:

  "Error: Unknown error" => "Error: "

Which is what r66616 did as expected.
http://trac.webkit.org/changeset/66616/trunk/JavaScriptCore/runtime/ErrorPrototype.cpp

Sounds to me like we just need to check in updated results.

it also looks like v8 already has the empty error message. So you could check to see
if we can remove the chromium platform specific results after reseting the results:
LayoutTests/platform/chromium/inspector/console-format-expected.txt
Comment 3 Joseph Pecoraro 2010-09-01 16:06:09 PDT 
Comment on attachment 66295 [details]
Fix failing test

Looks good. Thanks! I'll see if this can get landed sooner
than the commit queue.
Comment 4 Gavin Barraclough 2010-09-01 16:07:26 PDT 
Ooops! apologies for the breakage, thank you for fixing.
Comment 5 Joseph Pecoraro 2010-09-01 16:27:58 PDT 
Committed r66625
	M	LayoutTests/inspector/console-format-expected.txt
	M	LayoutTests/ChangeLog
r66625 = 2f15e0a53e38f4e30aeaf5ab4bc394f5c9ebca51
http://trac.webkit.org/changeset/66625