Bug 45063 - [Chromium] Update test results server to make sure it does not have corrupted data
Summary: [Chromium] Update test results server to make sure it does not have corrupted...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Victor Wang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-01 14:56 PDT by Victor Wang
Modified: 2010-09-08 15:16 PDT (History)
1 user (show)

See Also:

Attachments
Proposed Patch (3.35 KB, patch)
2010-09-01 15:09 PDT, Victor Wang 		ojan: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Victor Wang 2010-09-01 14:56:27 PDT 
The results.json file size could be >1M (data store entry limit), so we split it into multiple data store entries in this case.
The current test results server may leave the data in corrupted state if data store error happens in the middle of saving multiple entries. To fix this, we should save keys to the new data entries separately and set the data_keys in DataStoreFile only when all data are saved successfully. This avoids the issue that only partial results are saved.
Comment 1 Victor Wang 2010-09-01 15:09:15 PDT 
Created attachment 66285 [details]
Proposed Patch
Comment 2 Ojan Vafai 2010-09-08 14:32:54 PDT 
Comment on attachment 66285 [details]
Proposed Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=66285&action=prettypatch

> WebKitTools/ChangeLog:11
> +        be corrupted if data store error happens in teh middle
typo: teh
Comment 3 Victor Wang 2010-09-08 15:16:48 PDT 
Committed r67024: <http://trac.webkit.org/changeset/67024>