Bug 45054 – Share more code between HTMLObjectElement and HTMLEmbedElement

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Eric Seidel (no email)]

Share more code between HTMLObjectElement and HTMLEmbedElement

[Eric Seidel (no email)]

Created attachment 66254 [details]
Patch

[Dimitri Glazkov (Google)]

Comment on attachment 66254 [details]
Patch

This looks great!

View in context: https://bugs.webkit.org/attachment.cgi?id=66254&action=prettypatch

> WebCore/html/HTMLObjectElement.h:64
> +    
Extra whitespace here.

> WebCore/html/HTMLPlugInElement.cpp:70
> +    
And here.

[Eric Seidel (no email)]

Whitespace has been cleaned up some in later patches.  Gonna see if this cq's clean.

[WebKit Commit Bot]

Comment on attachment 66254 [details]
Patch

Rejecting patch 66254 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--wait-for-httpd', '--ignore-tests', 'compositing,media', '--quiet']" exit_code: 1
Running build-dumprendertree
Compiling Java tests
make: Nothing to be done for `default'.
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 20898 test cases.
svg/custom/getsvgdocument.html -> failed

Exiting early after 1 failures. 18060 tests run.
370.48s total testing time

18059 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
26 test cases (<1%) had stderr output

Full output: http://queues.webkit.org/results/3926037

[Eric Seidel (no email)]

Fixing.  Will repost for landing shortly.

[Eric Seidel (no email)]

I'm going to land this in smaller pieces.  I can't seem to find the regression in the moving code, but I'll make sure all the pieces I land land w/o regression.

[Eric Seidel (no email)]

Landing this in two pieces.  First part landed as r66650.

[Eric Seidel (no email)]

Piece 2 as r66653

[Eric Seidel (no email)]

Actually it's going to be 3 pieces.  I've reduced the diff causing the failure, now just trying to figure out what part of it is wrong. :)

[Eric Seidel (no email)]

I guess it's going to be 4 pieces.  #3 was r66657.  I'm down to only like 50 lines left.  Still haven't found the bug.

[Eric Seidel (no email)]

Turns out the insanity that is:

void HTMLPlugInImageElement::recalcStyle(StyleChange ch)
{
    // FIXME: Why is this necessary?  Manual re-attach is almost always wrong.
    if (!useFallbackContent() && needsWidgetUpdate() && renderer() && !isImageType()) {
        detach();
        attach();
    }
    HTMLPlugInElement::recalcStyle(ch);
}

needed to be moved from <object> down to the base class too.  Who knows why.  This code is black magic.

[Eric Seidel (no email)]

Committed r66659: <http://trac.webkit.org/changeset/66659>