ScrollbarThemeGtk should be enabled for interior frame scrollbars. This will specialize ScrollbarGtk.cpp to only apply to main-frame scrollbars and remove all code in that unit for interior frame scrollbars. This means that interior frame scrollbars will work just as they do for all other ports and greatly reduces the code complexity. Further benefits: For WebKit2 clicks will not have to be routed through GTK+ and can simply go straight to WebCore. Additionally, it will allow us to add a switch (if we desire) to toggle the behavior of main frame scrollbars (for instance, if we wish to pass some failing layout tests).
Created attachment 66236 [details] Enable ScrollbarThemeGtk
Comment on attachment 66236 [details] Enable ScrollbarThemeGtk 183 // FIXME: Restructure the ScrollView abstraction so that we do not have to 184 // copy this verbatim from ScrollView.cpp. Until then, we should make sure this 185 // is kept in sync. 186 bool needsUpdate = false; Yeah =(. I like that we are being able to further isolate the more specific stuff into their own smaller compartments, though.
Wow. Thanks for the review. That's a wrap for scrollbar stuff. Enabling / disabling the current main frame behavior should only be a couple-line change if we need to do it for WebKit2.
Comment on attachment 66236 [details] Enable ScrollbarThemeGtk Clearing flags on attachment: 66236 Committed r66848: <http://trac.webkit.org/changeset/66848>
All reviewed patches have been landed. Closing bug.
It seems testwebview started to crash after this patch landed: http://webkit-bots.igalia.com/amd64/svn_66871.core-when_1283853203-_-who_testwebview-_-why_11.7435.trace.html Looking into it