AECHAR is the wide-char type for BREWMP. Add a String(AECHAR*) constructor for convenience.
Created attachment 66221 [details] Patch Patch (WTFString.h)
Created attachment 66222 [details] Patch (StringBrew.cpp)
Attachment 66222 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/platform/text/brew/StringBrew.cpp:27: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebCore/platform/text/brew/StringBrew.cpp:30: Alphabetical sorting problem. [build/include_order] [4] WebCore/platform/text/brew/StringBrew.cpp:32: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 3 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 66224 [details] Patch (StringBrew.cpp) I accidentally included <String.h>. Remove it.
Attachment 66224 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/platform/text/brew/StringBrew.cpp:27: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebCore/platform/text/brew/StringBrew.cpp:30: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 66226 [details] Patch (StringBrew.cpp) wtf/CString.h is not required here too. Remove it.
Attachment 66226 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/platform/text/brew/StringBrew.cpp:27: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 66227 [details] Patch (StringBrew.cpp) Fix style errors. Put a blank line between the primary header and other header files.
Attachment 66227 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/platform/text/brew/StringBrew.cpp:27: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #9) > Attachment 66227 [details] did not pass style-queue: > > Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 > WebCore/platform/text/brew/StringBrew.cpp:27: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] > Total errors found: 1 in 2 files > > > If any of these errors are false positives, please file a bug against check-webkit-style. I think this is a false-positive report because the primary header for StringBrew.cpp is indeed PlatformString.h.
Comment on attachment 66221 [details] Patch ok
Comment on attachment 66227 [details] Patch (StringBrew.cpp) ok
Comment on attachment 66221 [details] Patch Clearing flags on attachment: 66221 Committed r70288: <http://trac.webkit.org/changeset/70288>
The commit-queue encountered the following flaky tests while processing attachment 66227 [details]: http/tests/appcache/remove-cache.html Please file bugs against the tests. The author(s) of the test(s) are ap@webkit.org and ap@webkit.org. The commit-queue is continuing to process your patch.
Comment on attachment 66227 [details] Patch (StringBrew.cpp) Clearing flags on attachment: 66227 Committed r70294: <http://trac.webkit.org/changeset/70294>
All reviewed patches have been landed. Closing bug.