Bug 45042 - [cairo] Include support for rotations to the GraphicsContext::drawTiledShadow
Summary: [cairo] Include support for rotations to the GraphicsContext::drawTiledShadow
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 90082
  Show dependency tree / graph
 
Reported: 2010-09-01 09:22 PDT by Alejandro G. Castro
Modified: 2016-01-26 09:24 PST (History)
7 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alejandro G. Castro 2010-09-01 09:22:43 PDT 
Currently drawTiledShadow can just be used if the GraphicContext is not rotated, there are subpixel problems in the tiled regions.
Comment 1 Dominik Röttsches (drott) 2012-06-04 05:03:34 PDT 
Alejandro, do you have any example or screenshot of what's going wrong? Or any test case names that are affected by this?
Comment 2 Alejandro G. Castro 2012-06-11 02:25:02 PDT 
(In reply to comment #1)
> Alejandro, do you have any example or screenshot of what's going wrong? Or any test case names that are affected by this?

Sorry for the late answer, I'm not sure about the current situation of this issue. This bug comes from when we initially implemented tiling in ContextShadow. I thought Simon added a fix to this problem in ShadowBlur, that replaced ContextShadow but I've just checked the condition is still in the code. Basically the tiling when rotated showed some visual artifacts, you can test it forcing tiling (big shadowed rect), adding some rotation and commenting the lines that avoids the tiling in these cases in ShadowBlur.cpp.

Adding Sam so he can add information about current situation.

I hope this helps.
Comment 3 Alejandro G. Castro 2016-01-26 09:24:28 PST 
Currently this does not make sense anymore.