RESOLVED FIXED 45027
The code calling ImageBuffer::create should check if the image is actually created 
https://bugs.webkit.org/show_bug.cgi?id=45027
Summary The code calling ImageBuffer::create should check if the image is actually cr...
Alejandro G. Castro
Reported 2010-09-01 01:51:01 PDT
ImageBuffer::create can return 0, we have to review if we are checking it correctly where we call it.
Attachments
Proposed patch (10.79 KB, patch)
2010-09-01 02:08 PDT, Alejandro G. Castro 		no flags
DetailsFormatted DiffDiff
Proposed patch (10.78 KB, patch)
2010-09-01 05:11 PDT, Alejandro G. Castro 		no flags
DetailsFormatted DiffDiff
Proposed patch (10.78 KB, patch)
2010-09-01 06:00 PDT, Alejandro G. Castro 		levin: review-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alejandro G. Castro
Comment 1 2010-09-01 02:08:03 PDT
Created attachment 66181 [details] Proposed patch Looked for the places where the function is used and checked the return value and in some situations also the value returned by that function if we are getting the context of the ImageBuffer.
Eric Seidel (no email)
Comment 2 2010-09-01 02:19:55 PDT
Attachment 66181 [details] did not build on mac: Build output: http://queues.webkit.org/results/3937010
Alejandro G. Castro
Comment 3 2010-09-01 05:11:05 PDT
Created attachment 66203 [details] Proposed patch Fixed compilation issue in mac.
Dirk Schulze
Comment 4 2010-09-01 05:14:11 PDT
Comment on attachment 66203 [details] Proposed patch I guess you didn't want to r+ your own patch, right? :-P
Alejandro G. Castro
Comment 5 2010-09-01 05:14:54 PDT
(In reply to comment #4) > (From update of attachment 66203 [details]) > I guess you didn't want to r+ your own patch, right? :-P :) yeah, sorry
Dirk Schulze
Comment 6 2010-09-01 05:15:01 PDT
Comment on attachment 66203 [details] Proposed patch It's better when you request the review for your self again. Just mark it r?.
WebKit Review Bot
Comment 7 2010-09-01 05:45:19 PDT
Attachment 66181 [details] did not build on chromium: Build output: http://queues.webkit.org/results/3903017
Alejandro G. Castro
Comment 8 2010-09-01 06:00:26 PDT
Created attachment 66205 [details] Proposed patch Fixed cr-linux compilation.
chris fleizach
Comment 9 2010-09-22 00:21:40 PDT
Comment on attachment 66205 [details] Proposed patch do you have any instances where this is occurring? if so, can you add a layout test.
Alejandro G. Castro
Comment 10 2010-10-04 02:57:57 PDT
(In reply to comment #9) > (From update of attachment 66205 [details]) > do you have any instances where this is occurring? > if so, can you add a layout test. I don't just a cleaning found by Dirk in other patch when using this function.
David Levin
Comment 11 2010-10-17 16:53:57 PDT
Comment on attachment 66205 [details] Proposed patch Needs a layout test or an explanation (in the ChangeLog) of why one isn't possible.
Alejandro G. Castro
Comment 12 2018-08-23 02:54:08 PDT
I doubt this bug is relevant anymore, most of the code it was changing is long gone.
Note You need to log in before you can comment on or make changes to this bug.