Bug 45027 - The code calling ImageBuffer::create should check if the image is actually created
Summary: The code calling ImageBuffer::create should check if the image is actually cr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-01 01:51 PDT by Alejandro G. Castro
Modified: 2018-08-23 02:54 PDT (History)
4 users (show)

See Also:

Attachments
Proposed patch (10.79 KB, patch)
2010-09-01 02:08 PDT, Alejandro G. Castro 		no flags Details | Formatted Diff | Diff
Proposed patch (10.78 KB, patch)
2010-09-01 05:11 PDT, Alejandro G. Castro 		no flags Details | Formatted Diff | Diff
Proposed patch (10.78 KB, patch)
2010-09-01 06:00 PDT, Alejandro G. Castro 		levin: review-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alejandro G. Castro 2010-09-01 01:51:01 PDT 
ImageBuffer::create can return 0, we have to review if we are checking it correctly where we call it.
Comment 1 Alejandro G. Castro 2010-09-01 02:08:03 PDT 
Created attachment 66181 [details]
Proposed patch

Looked for the places where the function is used and checked the return value and in some situations also the value returned by that function if we are getting the context of the ImageBuffer.
Comment 2 Eric Seidel (no email) 2010-09-01 02:19:55 PDT 
Attachment 66181 [details] did not build on mac:
Build output: http://queues.webkit.org/results/3937010
Comment 3 Alejandro G. Castro 2010-09-01 05:11:05 PDT 
Created attachment 66203 [details]
Proposed patch

Fixed compilation issue in mac.
Comment 4 Dirk Schulze 2010-09-01 05:14:11 PDT 
Comment on attachment 66203 [details]
Proposed patch

I guess you didn't want to r+ your own patch, right? :-P
Comment 5 Alejandro G. Castro 2010-09-01 05:14:54 PDT 
(In reply to comment #4)
> (From update of attachment 66203 [details])
> I guess you didn't want to r+ your own patch, right? :-P

:) yeah, sorry
Comment 6 Dirk Schulze 2010-09-01 05:15:01 PDT 
Comment on attachment 66203 [details]
Proposed patch

It's better when you request the review for your self again. Just mark it r?.
Comment 7 WebKit Review Bot 2010-09-01 05:45:19 PDT 
Attachment 66181 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/3903017
Comment 8 Alejandro G. Castro 2010-09-01 06:00:26 PDT 
Created attachment 66205 [details]
Proposed patch

Fixed cr-linux compilation.
Comment 9 chris fleizach 2010-09-22 00:21:40 PDT 
Comment on attachment 66205 [details]
Proposed patch

do you have any instances where this is occurring? 
if so, can you add a layout test.
Comment 10 Alejandro G. Castro 2010-10-04 02:57:57 PDT 
(In reply to comment #9)
> (From update of attachment 66205 [details])
> do you have any instances where this is occurring? 
> if so, can you add a layout test.

I don't just a cleaning found by Dirk in other patch when using this function.
Comment 11 David Levin 2010-10-17 16:53:57 PDT 
Comment on attachment 66205 [details]
Proposed patch

Needs a layout test or an explanation (in the ChangeLog) of why one isn't possible.
Comment 12 Alejandro G. Castro 2018-08-23 02:54:08 PDT 
I doubt this bug is relevant anymore, most of the code it was changing is long gone.