Bug 45011 – [EFL] Regression (66531) Build break with Glib Support

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Ryuan Choi]

r65531 isolate glib/gtk related typedef into one file.
It looks good but EFL need some of typedef because of glib support

[Ryuan Choi]

Created attachment 66161 [details]
Patch

[WebKit Review Bot]

Attachment 66161 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
JavaScriptCore/wtf/efl/EflTypedefs.h:40:  cairo_surface_t is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Ryuan Choi]

Created attachment 66163 [details]
Patch

[Leandro Pereira]

Looks good to me, but I wonder if would be a nicer idea to share this header file with the GTK+ port somehow. Perhaps move it to gobject/ and call it GTypedefs.h? I'm CC'ing some of the GTK+ guys to see if they think this is a good idea.

[Ryuan Choi]

(In reply to comment #4)
> Looks good to me, but I wonder if would be a nicer idea to share this header file with the GTK+ port somehow. Perhaps move it to gobject/ and call it GTypedefs.h? I'm CC'ing some of the GTK+ guys to see if they think this is a good idea.

I agree, If GTK+ guys agree, we'd better to use seperated GTypedefs.h from GtkTypedefs.h.

I'll prepare it.

[Martin Robinson]

I think the right thing to do here is to move GtkTypedefs.h to GTypedefs.h and hide the GTK+-specific stuff behind a PLATFORM(GTK). It seems like serious overkill to have an entire include just for the GTK+ stuff.

[Lucas De Marchi]

Created attachment 66493 [details]
Patch

[WebKit Review Bot]

Attachment 66493 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
JavaScriptCore/wtf/gobject/GTypedefs.h:57:  cairo_surface_t is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Martin Robinson]

Comment on attachment 66493 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=66493&action=prettypatch

> JavaScriptCore/wtf/gobject/GTypedefs.h:57
> +typedef struct _cairo_surface cairo_surface_t;
This typedef should really be behind a PLATFORM(CAIRO), I think.

[Lucas De Marchi]

Created attachment 66509 [details]
Patch

[WebKit Review Bot]

Attachment 66509 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
JavaScriptCore/wtf/gobject/GTypedefs.h:57:  cairo_surface_t is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Martin Robinson]

Comment on attachment 66509 [details]
Patch

LGTM.

[Lucas De Marchi]

Comment on attachment 66509 [details]
Patch

Clearing flags on attachment: 66509

Committed r66738: <http://trac.webkit.org/changeset/66738>

[Lucas De Marchi]

All reviewed patches have been landed.  Closing bug.