Bug 45011 - [EFL] Regression (66531) Build break with Glib Support
Summary: [EFL] Regression (66531) Build break with Glib Support
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-31 17:52 PDT by Ryuan Choi
Modified: 2010-09-03 10:07 PDT (History)
6 users (show)

See Also:


Attachments
Patch (6.18 KB, patch)
2010-08-31 19:49 PDT, Ryuan Choi
no flags Details | Formatted Diff | Diff
Patch (6.13 KB, patch)
2010-08-31 20:19 PDT, Ryuan Choi
no flags Details | Formatted Diff | Diff
Patch (5.93 KB, patch)
2010-09-03 07:51 PDT, Lucas De Marchi
no flags Details | Formatted Diff | Diff
Patch (5.96 KB, patch)
2010-09-03 09:24 PDT, Lucas De Marchi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2010-08-31 17:52:50 PDT
r65531 isolate glib/gtk related typedef into one file.
It looks good but EFL need some of typedef because of glib support
Comment 1 Ryuan Choi 2010-08-31 19:49:11 PDT
Created attachment 66161 [details]
Patch
Comment 2 WebKit Review Bot 2010-08-31 19:52:28 PDT
Attachment 66161 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
JavaScriptCore/wtf/efl/EflTypedefs.h:40:  cairo_surface_t is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Ryuan Choi 2010-08-31 20:19:34 PDT
Created attachment 66163 [details]
Patch
Comment 4 Leandro Pereira 2010-09-01 12:22:34 PDT
Looks good to me, but I wonder if would be a nicer idea to share this header file with the GTK+ port somehow. Perhaps move it to gobject/ and call it GTypedefs.h? I'm CC'ing some of the GTK+ guys to see if they think this is a good idea.
Comment 5 Ryuan Choi 2010-09-02 00:20:37 PDT
(In reply to comment #4)
> Looks good to me, but I wonder if would be a nicer idea to share this header file with the GTK+ port somehow. Perhaps move it to gobject/ and call it GTypedefs.h? I'm CC'ing some of the GTK+ guys to see if they think this is a good idea.

I agree, If GTK+ guys agree, we'd better to use seperated GTypedefs.h from GtkTypedefs.h.

I'll prepare it.
Comment 6 Martin Robinson 2010-09-02 10:38:08 PDT
I think the right thing to do here is to move GtkTypedefs.h to GTypedefs.h and hide the GTK+-specific stuff behind a PLATFORM(GTK). It seems like serious overkill to have an entire include just for the GTK+ stuff.
Comment 7 Lucas De Marchi 2010-09-03 07:51:34 PDT
Created attachment 66493 [details]
Patch
Comment 8 WebKit Review Bot 2010-09-03 07:54:02 PDT
Attachment 66493 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
JavaScriptCore/wtf/gobject/GTypedefs.h:57:  cairo_surface_t is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 9 Martin Robinson 2010-09-03 08:55:48 PDT
Comment on attachment 66493 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=66493&action=prettypatch

> JavaScriptCore/wtf/gobject/GTypedefs.h:57
> +typedef struct _cairo_surface cairo_surface_t;
This typedef should really be behind a PLATFORM(CAIRO), I think.
Comment 10 Lucas De Marchi 2010-09-03 09:24:17 PDT
Created attachment 66509 [details]
Patch
Comment 11 WebKit Review Bot 2010-09-03 09:25:40 PDT
Attachment 66509 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
JavaScriptCore/wtf/gobject/GTypedefs.h:57:  cairo_surface_t is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 12 Martin Robinson 2010-09-03 10:01:51 PDT
Comment on attachment 66509 [details]
Patch

LGTM.
Comment 13 Lucas De Marchi 2010-09-03 10:07:47 PDT
Comment on attachment 66509 [details]
Patch

Clearing flags on attachment: 66509

Committed r66738: <http://trac.webkit.org/changeset/66738>
Comment 14 Lucas De Marchi 2010-09-03 10:07:56 PDT
All reviewed patches have been landed.  Closing bug.