Bug 45010 - Add AudioSourceNode files
Summary: Add AudioSourceNode files
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2010-08-31 17:26 PDT by Chris Rogers
Modified: 2010-09-09 20:31 PDT (History)
8 users (show)

See Also:

Patch (5.42 KB, patch)
2010-08-31 17:27 PDT, Chris Rogers
no flags Details | Formatted Diff | Diff
Patch (4.66 KB, patch)
2010-09-08 17:42 PDT, Chris Rogers
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Rogers 2010-08-31 17:26:28 PDT
Add AudioSourceNode files
Comment 1 Chris Rogers 2010-08-31 17:27:53 PDT
Created attachment 66146 [details]
Comment 2 Chris Rogers 2010-09-07 14:45:36 PDT
Here's the link to AudioSourceNode in the web audio API spec:

This patch implements two attributes which are not in the spec.  I either need to change the spec or change the implementation, but it will require some thought to determine how to best design this and I would like to land this, even if it involves adding a FIXME to reconcile API.
Comment 3 Kenneth Russell 2010-09-07 17:59:15 PDT
Comment on attachment 66146 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=66146&action=prettypatch

> WebCore/webaudio/AudioSourceNode.idl:34
> +        readonly attribute AudioParam playbackRate;
Why are these attributes not documented in the preliminary web audio API ( http://chromium.googlecode.com/svn/trunk/samples/audio/specification/specification.html#AudioSourceNode-section )?
Comment 4 Chris Rogers 2010-09-08 17:42:36 PDT
Created attachment 66973 [details]
Comment 5 Chris Rogers 2010-09-08 17:44:17 PDT
Ok, I've moved the attributes out of this class to match the current specification.
Comment 6 Kenneth Russell 2010-09-09 14:08:42 PDT
Comment on attachment 66973 [details]

Looks fine. Sorry I didn't see your note above when doing my initial review, though I think it's better to keep this class in line with the spec.
Comment 7 WebKit Commit Bot 2010-09-09 20:31:03 PDT
Comment on attachment 66973 [details]

Clearing flags on attachment: 66973

Committed r67157: <http://trac.webkit.org/changeset/67157>
Comment 8 WebKit Commit Bot 2010-09-09 20:31:08 PDT
All reviewed patches have been landed.  Closing bug.