Bug 45009 – Add AudioDestinationNode files

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Chris Rogers]

Add AudioDestinationNode files

[Chris Rogers]

Created attachment 66145 [details]
Patch

[Chris Rogers]

Implements AudioDestinationNode as described in the web audio specification:

http://chromium.googlecode.com/svn/trunk/samples/audio/specification/specification.html#AudioDestinationNode-section

[Kenneth Russell]

Comment on attachment 66145 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=66145&action=prettypatch

Generally looks fine; r- because of an inconsistency in the publicly visible attributes. Also a couple of minor suggestions.

> WebCore/webaudio/AudioDestinationNode.cpp:50
> +    initialize();
I certainly hope that AudioNode initializes the m_isInitialized flag to false in its constructor. It would be simpler if AudioNode were landed before this class which depends on it.

> WebCore/webaudio/AudioDestinationNode.cpp:71
> +    m_isInitialized = true;
I would suggest just calling AudioNode::initialize() here and making m_isInitialized private in AudioNode (assuming that's where it's declared).

> WebCore/webaudio/AudioDestinationNode.cpp:81
> +    m_isInitialized = false;
Same comment, but about calling AudioNode::uninitialize().

> WebCore/webaudio/AudioDestinationNode.idl:34
> +        readonly attribute short numberOfChannels;
This attribute isn't currently in the Web Audio spec.

[Chris Rogers]

Created attachment 68416 [details]
Patch

[Chris Rogers]

Ken, I've created a new patch to address some changes to AudioContext.  I've added the "numberOfChannels" attribute to the web audio specification document.  I spoke with you offline about keeping the initialize/uninitialize part as it is.  But I *did* add addInput() and addOutput() methods to AudioNode.

[Kenneth Russell]

Comment on attachment 68416 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=68416&action=review

Looks fine. Tiny formatting issue.

> WebCore/webaudio/AudioDestinationNode.h:54
> +    virtual void reset() { m_currentTime = 0.0; };

No semicolons at end of lines.

[WebKit Commit Bot]

Comment on attachment 68416 [details]
Patch

Clearing flags on attachment: 68416

Committed r68540: <http://trac.webkit.org/changeset/68540>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.