Bug 45006 - Add AudioListener files
Summary: Add AudioListener files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-31 16:50 PDT by Chris Rogers
Modified: 2010-09-03 11:52 PDT (History)
7 users (show)

See Also:

Attachments
Patch (9.57 KB, patch)
2010-08-31 16:51 PDT, Chris Rogers 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Rogers 2010-08-31 16:50:12 PDT 
Add AudioListener files
Comment 1 Chris Rogers 2010-08-31 16:51:29 PDT 
Created attachment 66141 [details]
Patch
Comment 2 Chris Rogers 2010-08-31 16:53:11 PDT 
Implements AudioListener as described in the web audio specification:

http://chromium.googlecode.com/svn/trunk/samples/audio/specification/specification.html#AudioListener-section

Also of interest is how listener is described in the OpenAL specification.
Comment 3 Kenneth Russell 2010-09-02 16:22:22 PDT 
Comment on attachment 66141 [details]
Patch

Looks fine to me. I was going to argue about the naming of setOrientation taking the six double arguments, but see that that's exposed in the JavaScript API. It might be worth a FIXME at the top to change this to using FloatPoint3D rather than Vector3 once FloatPoint3D has been moved to a more general place than platform/graphics. (Or you could just cut it over now in anticipation of the move.) You could also consider switching over to single-precision floating point numbers everywhere in the implementation if they provide sufficient precision and range.
Comment 4 Chris Rogers 2010-09-03 11:51:59 PDT 
Comment on attachment 66141 [details]
Patch

Clearing flags on attachment: 66141

Committed r66750: <http://trac.webkit.org/changeset/66750>
Comment 5 Chris Rogers 2010-09-03 11:52:04 PDT 
All reviewed patches have been landed.  Closing bug.