RESOLVED FIXED 45006
Add AudioListener files 
https://bugs.webkit.org/show_bug.cgi?id=45006
Summary Add AudioListener files
Chris Rogers
Reported 2010-08-31 16:50:12 PDT
Add AudioListener files
Attachments
Patch (9.57 KB, patch)
2010-08-31 16:51 PDT, Chris Rogers 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Rogers
Comment 1 2010-08-31 16:51:29 PDT
Created attachment 66141 [details] Patch
Chris Rogers
Comment 2 2010-08-31 16:53:11 PDT
Implements AudioListener as described in the web audio specification: http://chromium.googlecode.com/svn/trunk/samples/audio/specification/specification.html#AudioListener-section Also of interest is how listener is described in the OpenAL specification.
Kenneth Russell
Comment 3 2010-09-02 16:22:22 PDT
Comment on attachment 66141 [details] Patch Looks fine to me. I was going to argue about the naming of setOrientation taking the six double arguments, but see that that's exposed in the JavaScript API. It might be worth a FIXME at the top to change this to using FloatPoint3D rather than Vector3 once FloatPoint3D has been moved to a more general place than platform/graphics. (Or you could just cut it over now in anticipation of the move.) You could also consider switching over to single-precision floating point numbers everywhere in the implementation if they provide sufficient precision and range.
Chris Rogers
Comment 4 2010-09-03 11:51:59 PDT
Comment on attachment 66141 [details] Patch Clearing flags on attachment: 66141 Committed r66750: <http://trac.webkit.org/changeset/66750>
Chris Rogers
Comment 5 2010-09-03 11:52:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.