Bug 44998 - [GTK] warning: unused variable "queryResult"
Summary: [GTK] warning: unused variable "queryResult"
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P3 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2010-08-31 15:14 PDT by Martin Robinson
Modified: 2010-09-01 23:50 PDT (History)
2 users (show)

See Also:

Attachments
Patch for this issue (1.65 KB, patch)
2010-08-31 17:00 PDT, Martin Robinson 		no flags Details | Formatted Diff | Diff
second fix proposal (2.07 KB, patch)
2010-09-01 12:52 PDT, Philippe Normand 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2010-08-31 15:14:34 PDT 
I see this warning on the build bots whenever WebCore/platform/graphics/gstreamer/GStreamerGWorld.cpp is built.
Comment 1 Martin Robinson 2010-08-31 17:00:41 PDT 
Created attachment 66143 [details]
Patch for this issue
Comment 2 WebKit Commit Bot 2010-08-31 21:28:01 PDT 
Comment on attachment 66143 [details]
Patch for this issue

Clearing flags on attachment: 66143

Committed r66573: <http://trac.webkit.org/changeset/66573>
Comment 3 WebKit Commit Bot 2010-08-31 21:28:05 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Philippe Normand 2010-09-01 12:52:51 PDT 
Created attachment 66248 [details]
second fix proposal
Comment 5 Philippe Normand 2010-09-01 12:54:49 PDT 
Reopening, with the patch commited the newsegment propagation is likely to fail if WebKitGTK has been built with gstreamer < 0.10.30
Comment 6 Martin Robinson 2010-09-01 12:56:46 PDT 
Comment on attachment 66248 [details]
second fix proposal

LGTM. Thanks for fixing this.
Comment 7 Philippe Normand 2010-09-01 23:49:42 PDT 
http://trac.webkit.org/changeset/66645