inspector/report-protocol-errors.html and report-API-errors.html, added in http://trac.webkit.org/changeset/66523 and http://trac.webkit.org/changeset/66516 are failing on chromium-win. Adding to test_expectations.txt for now. I'm not sure if they're correct or not. Here are the diffs from the bot: http://build.chromium.org/buildbot/layout_test_results/webkit-rel-webkit-org/results/layout-test-results/inspector/report-API-errors-wdiff.html http://build.chromium.org/buildbot/layout_test_results/webkit-rel-webkit-org/results/layout-test-results/inspector/report-protocol-errors-wdiff.html
Created attachment 66223 [details] [patch] initial version.
Comment on attachment 66223 [details] [patch] initial version. View in context: https://bugs.webkit.org/attachment.cgi?id=66223&action=prettypatch > LayoutTests/http/tests/inspector/inspector-test2.js:148 > +InspectorTest._addSniffer = function(receiver, methodName, override, opt_sticky, opt_replace) Just overwrite original function instead of calling addSniffer_
Created attachment 66230 [details] [patch] second iteration comment addressed.
Created attachment 66231 [details] [patch] second iteration. With the new patch.
Comment on attachment 66231 [details] [patch] second iteration. With the new patch. View in context: https://bugs.webkit.org/attachment.cgi?id=66231&action=prettypatch > LayoutTests/inspector/report-protocol-errors.html:39 > + InspectorBackend.disableDebugger(true, fire); I'd rather use another agent which is not always enabled in Chromium.
(In reply to comment #5) > (From update of attachment 66231 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=66231&action=prettypatch > > > LayoutTests/inspector/report-protocol-errors.html:39 > > + InspectorBackend.disableDebugger(true, fire); > I'd rather use another agent which is not always enabled in Chromium. it is the only agent which clean its pointer from InspectorController.
Comment on attachment 66231 [details] [patch] second iteration. With the new patch. Rejecting patch 66231 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Yury Semikhatsky', u'--force']" exit_code: 1 Parsed 4 diffs from patch file(s). patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/inspector/report-API-errors.html patching file LayoutTests/inspector/report-protocol-errors.html patching file LayoutTests/platform/chromium/test_expectations.txt Hunk #2 FAILED at 3147. 1 out of 2 hunks FAILED -- saving rejects to file LayoutTests/platform/chromium/test_expectations.txt.rej Full output: http://queues.webkit.org/results/3910045
Committed r66663 M LayoutTests/platform/chromium/test_expectations.txt M LayoutTests/inspector/report-API-errors.html M LayoutTests/inspector/report-protocol-errors.html M LayoutTests/ChangeLog r66663 = ce6270ca6c31866b56857621c7900634e441d1b9 (refs/remotes/trunk)
http://trac.webkit.org/changeset/66663 might have broken Leopard Intel Debug (Tests)