RESOLVED FIXED 44990
editing/selection/5354455-1 has incorrect description text 
https://bugs.webkit.org/show_bug.cgi?id=44990
Summary editing/selection/5354455-1 has incorrect description text
Evan Martin
Reported 2010-08-31 14:41:40 PDT
editing/selection/5354455-1 has incorrect description text
Attachments
Patch (59.20 KB, patch)
2010-08-31 14:44 PDT, Evan Martin 		no flags
DetailsFormatted DiffDiff
the new test, for your clicking pleasure (1.00 KB, text/html)
2010-08-31 14:46 PDT, Evan Martin 		no flags
Details
better test (992 bytes, text/html)
2010-08-31 14:52 PDT, Evan Martin 		no flags
Details
maybe working test (1.01 KB, text/html)
2010-08-31 15:16 PDT, Evan Martin 		no flags
Details
Patch (58.62 KB, patch)
2010-08-31 15:18 PDT, Evan Martin 		no flags
DetailsFormatted DiffDiff
mac leopard result (244 bytes, text/plain)
2010-08-31 15:22 PDT, Tony Chang 		no flags
Details
Patch (58.92 KB, patch)
2010-08-31 15:28 PDT, Evan Martin 		tony: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Evan Martin
Comment 1 2010-08-31 14:44:28 PDT
Created attachment 66109 [details] Patch
Evan Martin
Comment 2 2010-08-31 14:46:38 PDT
Created attachment 66110 [details] the new test, for your clicking pleasure
Evan Martin
Comment 3 2010-08-31 14:52:21 PDT
Created attachment 66113 [details] better test
Evan Martin
Comment 4 2010-08-31 15:16:46 PDT
Created attachment 66122 [details] maybe working test
Evan Martin
Comment 5 2010-08-31 15:18:04 PDT
Created attachment 66123 [details] Patch
Tony Chang
Comment 6 2010-08-31 15:22:49 PDT
Created attachment 66124 [details] mac leopard result Here's the mac leopard result.
Evan Martin
Comment 7 2010-08-31 15:28:34 PDT
Created attachment 66125 [details] Patch
Tony Chang
Comment 8 2010-08-31 15:33:26 PDT
Comment on attachment 66125 [details] Patch Can you double check to make sure this test is skipped on win, gtk, and qt? We can probably enable it now and just check in the win baseline.
Tony Chang
Comment 9 2010-10-01 16:21:39 PDT
Committed r68948: <http://trac.webkit.org/changeset/68948>
Ryosuke Niwa
Comment 10 2010-10-01 16:26:36 PDT
Comment on attachment 66125 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=66125&action=review Sorry, I came in too late. Should have paid more attention :( > LayoutTests/editing/selection/5354455-1.html:3 > +<p>This tests whether right clicking on a paragraph break in editable content selects it. The break should be selected on OS X, but not on Windows or Linux. To run it manually, right click on the paragraph break after the first paragraph below.</p> We probably would have wanted to move this into Markup.description. > LayoutTests/editing/selection/5354455-1.html:23 > +Markup.dump(document.getElementById("dump")); This can be simplified to Markup.dump("dump"); But nice change overall. You might be interested in an effort to automate this kind of test conversions (the bug 45100).
Note You need to log in before you can comment on or make changes to this bug.