Bug 44990 - editing/selection/5354455-1 has incorrect description text
Summary: editing/selection/5354455-1 has incorrect description text
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Evan Martin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-31 14:41 PDT by Evan Martin
Modified: 2010-10-01 16:26 PDT (History)
1 user (show)

See Also:


Attachments
Patch (59.20 KB, patch)
2010-08-31 14:44 PDT, Evan Martin
no flags Details | Formatted Diff | Diff
the new test, for your clicking pleasure (1.00 KB, text/html)
2010-08-31 14:46 PDT, Evan Martin
no flags Details
better test (992 bytes, text/html)
2010-08-31 14:52 PDT, Evan Martin
no flags Details
maybe working test (1.01 KB, text/html)
2010-08-31 15:16 PDT, Evan Martin
no flags Details
Patch (58.62 KB, patch)
2010-08-31 15:18 PDT, Evan Martin
no flags Details | Formatted Diff | Diff
mac leopard result (244 bytes, text/plain)
2010-08-31 15:22 PDT, Tony Chang
no flags Details
Patch (58.92 KB, patch)
2010-08-31 15:28 PDT, Evan Martin
tony: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Evan Martin 2010-08-31 14:41:40 PDT
editing/selection/5354455-1 has incorrect description text
Comment 1 Evan Martin 2010-08-31 14:44:28 PDT
Created attachment 66109 [details]
Patch
Comment 2 Evan Martin 2010-08-31 14:46:38 PDT
Created attachment 66110 [details]
the new test, for your clicking pleasure
Comment 3 Evan Martin 2010-08-31 14:52:21 PDT
Created attachment 66113 [details]
better test
Comment 4 Evan Martin 2010-08-31 15:16:46 PDT
Created attachment 66122 [details]
maybe working test
Comment 5 Evan Martin 2010-08-31 15:18:04 PDT
Created attachment 66123 [details]
Patch
Comment 6 Tony Chang 2010-08-31 15:22:49 PDT
Created attachment 66124 [details]
mac leopard result

Here's the mac leopard result.
Comment 7 Evan Martin 2010-08-31 15:28:34 PDT
Created attachment 66125 [details]
Patch
Comment 8 Tony Chang 2010-08-31 15:33:26 PDT
Comment on attachment 66125 [details]
Patch

Can you double check to make sure this test is skipped on win, gtk, and qt?  We can probably enable it now and just check in the win baseline.
Comment 9 Tony Chang 2010-10-01 16:21:39 PDT
Committed r68948: <http://trac.webkit.org/changeset/68948>
Comment 10 Ryosuke Niwa 2010-10-01 16:26:36 PDT
Comment on attachment 66125 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=66125&action=review

Sorry, I came in too late.  Should have paid more attention :(

> LayoutTests/editing/selection/5354455-1.html:3
> +<p>This tests whether right clicking on a paragraph break in editable content selects it.  The break should be selected on OS X, but not on Windows or Linux.  To run it manually, right click on the paragraph break after the first paragraph below.</p>

We probably would have wanted to move this into Markup.description.

> LayoutTests/editing/selection/5354455-1.html:23
> +Markup.dump(document.getElementById("dump"));

This can be simplified to Markup.dump("dump");

But nice change overall.  You might be interested in an effort to automate this kind of test conversions (the bug 45100).