Bug 44987 – Regression (r63528): HTTP headers not being set correctly for FrameLoadTypeReloadFromOrigin

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Nate Chapin]

Currently, the cache policy is being set correctly for subresources when the FrameLoader's load type is FrameLoadTypeReloadFromOrigin, but the additional headers (Cache-Control, Pragma) are not being correctly set.

[Nate Chapin]

Created attachment 66105 [details]
patch

[Darin Adler]

Comment on attachment 66105 [details]
patch

Can we add a regression test for this?

[Nate Chapin]

(In reply to comment #2)
> (From update of attachment 66105 [details])
> Can we add a regression test for this?

I'm happy to add a test, I just wasn't sure what kind was preferred, since DRT doesn't seem to be able to test this case.  Manual test perhaps?

[Darin Fisher (:fishd, Google)]

Comment on attachment 66105 [details]
patch

We could probably extend layoutTestController to add a queueReloadFromOrigin method.
I think it is fair to create a separate patch for that since it involves new DRT
functionality.

[Nate Chapin]

(In reply to comment #4)
> (From update of attachment 66105 [details])
> We could probably extend layoutTestController to add a queueReloadFromOrigin method.
> I think it is fair to create a separate patch for that since it involves new DRT
> functionality.

Filed and assigned to me: https://bugs.webkit.org/show_bug.cgi?id=44999

[Nate Chapin]

(In reply to comment #5)
> (In reply to comment #4)
> > (From update of attachment 66105 [details] [details])
> > We could probably extend layoutTestController to add a queueReloadFromOrigin method.
> > I think it is fair to create a separate patch for that since it involves new DRT
> > functionality.
> 
> Filed and assigned to me: https://bugs.webkit.org/show_bug.cgi?id=44999

http://trac.webkit.org/changeset/66549