Bug 44982 - ews: Add support for EFL-EWS
Summary: ews: Add support for EFL-EWS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Leandro Pereira
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-31 13:57 PDT by Leandro Pereira
Modified: 2010-09-01 04:59 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.59 KB, patch)
2010-08-31 14:03 PDT, Leandro Pereira
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Leandro Pereira 2010-08-31 13:57:58 PDT
ews: Add support for EFL-EWS
Comment 1 Leandro Pereira 2010-08-31 14:03:40 PDT
Created attachment 66100 [details]
Patch
Comment 2 Adam Barth 2010-08-31 16:40:11 PDT
Comment on attachment 66100 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=66100&action=prettypatch

> WebKitTools/Scripts/webkitpy/tool/commands/earlywarningsystem.py:114
> +class EflEWS(AbstractEarlyWarningSystem):
> +    name = "efl-ews"
> +    port_name = "efl"
Does the EFL port run on more than one platform?  If so, you might want to consider a name like efl-win-ews.  Once you pick a name, you're stuck with it.  :)
Comment 3 WebKit Commit Bot 2010-08-31 18:16:51 PDT
Comment on attachment 66100 [details]
Patch

Clearing flags on attachment: 66100

Committed r66564: <http://trac.webkit.org/changeset/66564>
Comment 4 WebKit Commit Bot 2010-08-31 18:16:55 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 WebKit Review Bot 2010-08-31 18:55:45 PDT
http://trac.webkit.org/changeset/66564 might have broken GTK Linux 64-bit Debug
The following changes are on the blame list:
http://trac.webkit.org/changeset/66561
http://trac.webkit.org/changeset/66562
http://trac.webkit.org/changeset/66563
http://trac.webkit.org/changeset/66564
Comment 6 Leandro Pereira 2010-09-01 04:58:02 PDT
(In reply to comment #5)
> http://trac.webkit.org/changeset/66564 might have broken GTK Linux 64-bit Debug
> The following changes are on the blame list:
> http://trac.webkit.org/changeset/66561
> http://trac.webkit.org/changeset/66562
> http://trac.webkit.org/changeset/66563
> http://trac.webkit.org/changeset/66564

Looks like a false alarm.
Comment 7 Leandro Pereira 2010-09-01 04:59:18 PDT
(In reply to comment #2)
> Does the EFL port run on more than one platform?  If so, you might want to consider a name like
> efl-win-ews.  Once you pick a name, you're stuck with it.  :)

Currently, only Linux is supported. EFL itself is portable, but I don't know if there are short-term plans to support other platforms.