build-webkit: Add support for CMake build system
Created attachment 66096 [details] Patch
I think you should also use cmake to build the files. This enables other port (with no make, eg. VisualStudio) to use buildCMakeProject too.
(In reply to comment #2) > I think you should also use cmake to build the files. > This enables other port (with no make, eg. VisualStudio) to use > buildCMakeProject too. OK, that's a good idea. I'll just wait for some reviewer to point out anything else I should take care of and submit another patch fixing everything in one go.
(In reply to comment #3) > (In reply to comment #2) > > I think you should also use cmake to build the files. > > This enables other port (with no make, eg. VisualStudio) to use > > buildCMakeProject too. > > OK, that's a good idea. I'll just wait for some reviewer to point out anything else I should take care of and submit another patch fixing everything in one go. Please, if you are going to submit a new patch with new contents anyways, please do it.
Looks fine to me. Darin can you have a look at the perl code?
It looks okay for me.
Comment on attachment 66096 [details] Patch Seems fine. I am sad to see all these options where you have to say what port to build, but I guess that battle was lost long ago.
Comment on attachment 66096 [details] Patch Forgot to cq? the patch :)
Comment on attachment 66096 [details] Patch Rejecting patch 66096 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Darin Adler', u'--force']" exit_code: 1 Parsed 3 diffs from patch file(s). patching file WebKitTools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebKitTools/Scripts/build-webkit Hunk #1 succeeded at 106 (offset 1 line). Hunk #2 FAILED at 247. Hunk #3 succeeded at 432 (offset 8 lines). 1 out of 3 hunks FAILED -- saving rejects to file WebKitTools/Scripts/build-webkit.rej patching file WebKitTools/Scripts/webkitdirs.pm Hunk #1 succeeded at 1408 (offset 1 line). Full output: http://queues.webkit.org/results/4019005
Created attachment 68152 [details] Patch
Comment on attachment 68152 [details] Patch This patch has been already reviewed bug failed to apply. Submitting a new version.
Comment on attachment 68152 [details] Patch Clearing flags on attachment: 68152 Committed r67911: <http://trac.webkit.org/changeset/67911>
All reviewed patches have been landed. Closing bug.