Bug 44976 - CommitQueue doesn't find reviewer in new ChangeLog file
Summary: CommitQueue doesn't find reviewer in new ChangeLog file
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2010-08-31 13:04 PDT by Patrick R. Gansterer
Modified: 2010-08-31 13:04 PDT (History)
0 users

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2010-08-31 13:04:18 PDT
When addinng a new ChangeLog file via CommitQueue and without a valid Reviewd by ... the patch will be rejected:

Unexpected failure when processing patch!  Please file a bug against webkit-patch.
Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'land-attachment', '--force-clean', '--build', '--non-interactive', '--ignore-builders', '--build-style=both', '--quiet', 65829, '--test', '--parent-command=commit-queue', '--no-update']" exit_code: 1
Last 500 characters of output:
webkitpy/tool/commands/stepsequence.py", line 64, in _run
    step(tool, options).run(state)
  File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 66, in run
    if self._has_valid_reviewer(changelog_entry):
  File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 48, in _has_valid_reviewer
    if changelog_entry.reviewer():
AttributeError: 'NoneType' object has no attribute 'reviewer'

From https://bugs.webkit.org/show_bug.cgi?id=44819#c2