Bug 44959 – [GTK] Leak in the GraphicsContextCairo drawPathShadow

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Alejandro G. Castro]

We are copying the cairo_path but we are not destroying it:

    cairo_path_t* path = cairo_copy_path(cr);

[Alejandro G. Castro]

Created attachment 66062 [details]
Proposed patch

[Gustavo Noronha (kov)]

Comment on attachment 66062 [details]
Proposed patch

Can't we use a PlatformRefPtr/CairoRefPtr for this?

[Alejandro G. Castro]

(In reply to comment #2)
> (From update of attachment 66062 [details])
> Can't we use a PlatformRefPtr/CairoRefPtr for this?

I've checked path is not already included, but I can do it in this same patch and use it, thanks for the comment.

[Alejandro G. Castro]

Created attachment 66198 [details]
Proposed patch

Added the GOwnPtrCairo code so we can use it in these situations.

[WebKit Review Bot]

Attachment 66198 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/platform/graphics/cairo/GOwnPtrCairo.h:31:  cairo_path_t is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alejandro G. Castro]

(In reply to comment #5)
> Attachment 66198 [details] did not pass style-queue:
> 
> Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
> WebCore/platform/graphics/cairo/GOwnPtrCairo.h:31:  cairo_path_t is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
> Total errors found: 1 in 4 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

Yep, it is a false positive. Opened bug 45032.

[Martin Robinson]

Comment on attachment 66198 [details]
Proposed patch

Looks reasonable.

[Alejandro G. Castro]

lande r67398