Bug 44956 - Paginate block-level replaced elements
Summary: Paginate block-level replaced elements
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-31 08:51 PDT by Dave Hyatt
Modified: 2010-08-31 09:30 PDT (History)
0 users

See Also:

Attachments
Patch (64.15 KB, patch)
2010-08-31 09:05 PDT, Dave Hyatt 		aroben: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2010-08-31 08:51:05 PDT 
This is filed as <rdar://problem/8000991> Images with display:block get split between columns or pages.

Make sure block-level replaced elements don't get split between multiple pages.
Comment 1 Dave Hyatt 2010-08-31 09:05:44 PDT 
Created attachment 66060 [details]
Patch
Comment 2 Adam Roben (:aroben) 2010-08-31 09:09:59 PDT 
Comment on attachment 66060 [details]
Patch

> WebCore/rendering/RenderBlock.cpp:2109
> +    RenderView* v = view();
I think "view" would be a better variable name (you'll have to initialize it using this->view() to avoid conflicts).

r=me
Comment 3 Dave Hyatt 2010-08-31 09:30:49 PDT 
FIxed in r66492.