Bug 44943 – Web Inspector: browser crashes on attempt to evaluate "alert(1)" while staying on a breakpoint

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Yury Semikhatsky]

Web Inspector: browser crashes on attempt to evaluate "alert(1)" while staying on a breakpoint. In fact the crash happens on any action that requires active dom objects to be suspended.

[Yury Semikhatsky]

Created attachment 66034 [details]
Patch

[Pavel Podivilov]

(In reply to comment #1)
> Created an attachment (id=66034) [details]
> Patch

Could you please use new test harness (inspector-test2.js)?

[Yury Semikhatsky]

Created attachment 66366 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 66366 [details]
Patch

> diff --git LayoutTests/inspector/debugger-suspend-active-dom-objects-expected.txt
> +Debugger was enabled.
> +Set timer for test function.
> +Script execution paused.
> +Shown alert while staying on a breakpoint
> +Script execution resumed.
> +Debugger was disabled.

Middle line is the only one with a period. Maybe add a period?
I had to have some comment in my review! =)


> +    setTimeout("void 0", 0); // Create a timer that will be suspended on a breakpoint.

I didn't know that `void` could be used like this. I thought it
needed parens. But, this is valid, so it can be left this way. Cool.


r=me as long as you ran LayoutTests and nothing else failed.

[Yury Semikhatsky]

66813(In reply to comment #4)
> (From update of attachment 66366 [details])
> > diff --git LayoutTests/inspector/debugger-suspend-active-dom-objects-expected.txt
> > +Debugger was enabled.
> > +Set timer for test function.
> > +Script execution paused.
> > +Shown alert while staying on a breakpoint
> > +Script execution resumed.
> > +Debugger was disabled.
> 
> Middle line is the only one with a period. Maybe add a period?
> I had to have some comment in my review! =)
> 
Done.

Committed r66813.