44925 – Move FileSystem related files from WebCore/storage to WebCore/fileapi.

Bug 44925 - Move FileSystem related files from WebCore/storage to WebCore/fileapi.

Summary: Move FileSystem related files from WebCore/storage to WebCore/fileapi.

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	WebCore Misc. (show other bugs)
Version:	528+ (Nightly build)
Hardware:	PC OS X 10.5

Importance:	P2 Normal
Assignee:	Nobody

URL:
Keywords:

Depends on:
Blocks:

Reported:	2010-08-30 19:43 PDT by Kinuko Yasuda
Modified:	2010-09-01 01:12 PDT (History)
CC List:	5 users (show)

See Also:

Attachments
Patch (89.53 KB, patch) 2010-08-30 20:30 PDT, Kinuko Yasuda	abarth: review+ abarth: commit-queue-	Details \| Formatted Diff \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Kinuko Yasuda 2010-08-30 19:43:56 PDT

Move FileSystem related files from WebCore/html to WebCore/fileapi.

Comment 1 Kinuko Yasuda 2010-08-30 20:30:15 PDT

(In reply to comment #0)
> Move FileSystem related files from WebCore/html to WebCore/fileapi.

Correction; Move FileSystem related files from WebCore/storage to WebCore/fileapi.

Comment 2 Kinuko Yasuda 2010-08-30 20:30:37 PDT

Created attachment 66007 [details]
Patch

Comment 3 Adam Barth 2010-08-30 20:40:36 PDT

Comment on attachment 66007 [details]
Patch

> WebCore/CMakeLists.txt:1593
> +if (ENABLE_FILE_SYSTEM)
> +    LIST(APPEND WebCore_SOURCES
> +        fileapi/DirectoryEntry.cpp
> +        fileapi/DirectoryReader.cpp
> +        fileapi/DOMFilePath.cpp
> +        fileapi/DOMFileSystem.cpp
> +        fileapi/Entry.cpp
> +        fileapi/EntryArray.cpp
> +        fileapi/FileEntry.cpp
> +        fileapi/FileSystemCallbacks.cpp
> +        fileapi/LocalFileSystem.cpp
> +        platform/AsyncFileSystem.cpp
> +    )
> +ENDIF ()
These weren't conditional before.  Also, what about the existing files in fileapi?  Should those be conditional too?

> WebCore/GNUmakefile.am:3052
> +       WebCore/fileapi/DirectoryEntry.cpp \
> +       WebCore/fileapi/DirectoryEntry.h \
> +       WebCore/fileapi/DirectoryReader.cpp \
> +       WebCore/fileapi/DirectoryReader.h \
> +       WebCore/fileapi/DOMFilePath.cpp \
> +       WebCore/fileapi/DOMFilePath.h \
> +       WebCore/fileapi/DOMFileSystem.cpp \
> +       WebCore/fileapi/DOMFileSystem.h \
> +       WebCore/fileapi/EntriesCallback.h \
> +       WebCore/fileapi/Entry.cpp \
> +       WebCore/fileapi/Entry.h \
> +       WebCore/fileapi/EntryArray.cpp \
> +       WebCore/fileapi/EntryArray.h \
> +       WebCore/fileapi/EntryCallback.h \
> +       WebCore/fileapi/ErrorCallback.h \
> +       WebCore/fileapi/FileEntry.cpp \
> +       WebCore/fileapi/FileEntry.h \
> +       WebCore/fileapi/FileSystemCallback.h \
> +       WebCore/fileapi/FileSystemCallbacks.cpp \
> +       WebCore/fileapi/FileSystemCallbacks.h \
> +       WebCore/fileapi/Flags.h \
> +       WebCore/fileapi/LocalFileSystem.cpp \
> +       WebCore/fileapi/LocalFileSystem.h \
> +       WebCore/fileapi/Metadata.h \
> +       WebCore/fileapi/MetadataCallback.h
Should these be textually next to the other fileapi files?

Comment 4 Kinuko Yasuda 2010-08-30 21:00:10 PDT

Thanks for reviewing.

(In reply to comment #3)
> (From update of attachment 66007 [details])
> > WebCore/CMakeLists.txt:1593
> > +if (ENABLE_FILE_SYSTEM)
> > +    LIST(APPEND WebCore_SOURCES
> > +        fileapi/DirectoryEntry.cpp
> > +        fileapi/DirectoryReader.cpp
> > +        fileapi/DOMFilePath.cpp
> > +        fileapi/DOMFileSystem.cpp
> > +        fileapi/Entry.cpp
> > +        fileapi/EntryArray.cpp
> > +        fileapi/FileEntry.cpp
> > +        fileapi/FileSystemCallbacks.cpp
> > +        fileapi/LocalFileSystem.cpp
> > +        platform/AsyncFileSystem.cpp
> > +    )
> > +ENDIF ()
> These weren't conditional before.  Also, what about the existing files in fileapi?  Should those be conditional too?

For now we don't need to build them if FILE_SYSTEM flag is not enabled, and there're no dependencies between existing files and files moved by this patch (yet).

> > WebCore/GNUmakefile.am:3052
> > +       WebCore/fileapi/DirectoryEntry.cpp \
> > +       WebCore/fileapi/DirectoryEntry.h \
> > +       WebCore/fileapi/DirectoryReader.cpp \
> > +       WebCore/fileapi/DirectoryReader.h \
> > +       WebCore/fileapi/DOMFilePath.cpp \
> > +       WebCore/fileapi/DOMFilePath.h \
> > +       WebCore/fileapi/DOMFileSystem.cpp \
> > +       WebCore/fileapi/DOMFileSystem.h \
> > +       WebCore/fileapi/EntriesCallback.h \
> > +       WebCore/fileapi/Entry.cpp \
> > +       WebCore/fileapi/Entry.h \
> > +       WebCore/fileapi/EntryArray.cpp \
> > +       WebCore/fileapi/EntryArray.h \
> > +       WebCore/fileapi/EntryCallback.h \
> > +       WebCore/fileapi/ErrorCallback.h \
> > +       WebCore/fileapi/FileEntry.cpp \
> > +       WebCore/fileapi/FileEntry.h \
> > +       WebCore/fileapi/FileSystemCallback.h \
> > +       WebCore/fileapi/FileSystemCallbacks.cpp \
> > +       WebCore/fileapi/FileSystemCallbacks.h \
> > +       WebCore/fileapi/Flags.h \
> > +       WebCore/fileapi/LocalFileSystem.cpp \
> > +       WebCore/fileapi/LocalFileSystem.h \
> > +       WebCore/fileapi/Metadata.h \
> > +       WebCore/fileapi/MetadataCallback.h
> Should these be textually next to the other fileapi files?

Same here, they are apart from others because they're in 'if ENABLE_FILE_SYSTEM' conditional.
I'll move them next to the other fileapi files once we start to compile them by default.

Comment 5 Kinuko Yasuda 2010-09-01 01:06:17 PDT

Committed r66586: <http://trac.webkit.org/changeset/66586>

Comment 6 WebKit Review Bot 2010-09-01 01:12:54 PDT

http://trac.webkit.org/changeset/66586 might have broken Qt Linux Release minimal, Qt Linux ARMv5 Release, and Qt Linux ARMv7 Release