44922 – [Chromium] bindTexture(TEXTURE_CUBE_MAP) shouldn't generate errors with valid cubemap texture

Bug 44922 - [Chromium] bindTexture(TEXTURE_CUBE_MAP) shouldn't generate errors with valid cubemap texture

Summary: [Chromium] bindTexture(TEXTURE_CUBE_MAP) shouldn't generate errors with valid...

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	WebGL (show other bugs)
Version:	528+ (Nightly build)
Hardware:	PC All

Importance:	P2 Normal
Assignee:	Zhenyao Mo

URL:
Keywords:

Depends on:
Blocks:

Reported:	2010-08-30 18:59 PDT by Zhenyao Mo
Modified:	2010-09-01 00:03 PDT (History)
CC List:	4 users (show)

See Also:

Attachments
patch (3.92 KB, patch) 2010-08-30 19:08 PDT, Zhenyao Mo	kbr: review+ zmo: commit-queue-	Details \| Formatted Diff \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Zhenyao Mo 2010-08-30 18:59:13 PDT

It's due to the code to set TEXTURE_WRAP_R to CLAMP_TO_EDGE.  Remove it for now.

Comment 1 Zhenyao Mo 2010-08-30 19:08:18 PDT

Created attachment 66000 [details]
patch

Comment 2 Kenneth Russell 2010-08-31 10:28:50 PDT

Comment on attachment 66000 [details]
patch

Looks good to me. r=me

Comment 3 Zhenyao Mo 2010-08-31 11:01:59 PDT

Committed r66509: <http://trac.webkit.org/changeset/66509>

Comment 4 WebKit Review Bot 2010-09-01 00:03:22 PDT

http://trac.webkit.org/changeset/66509 might have broken Leopard Intel Debug (Tests)
The following changes are on the blame list:
http://trac.webkit.org/changeset/66505
http://trac.webkit.org/changeset/66506
http://trac.webkit.org/changeset/66507
http://trac.webkit.org/changeset/66508
http://trac.webkit.org/changeset/66509